src: check against platform specific versions for latest and unstable #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpminardi
force-pushed
the
mpminardi/latest-fix
branch
from
1010197 to
9cd49c2
Compare
mpminardi
force-pushed
the
mpminardi/gitattributes
branch
from
566354e to
c17f550
Compare
mpminardi
force-pushed
the
mpminardi/latest-fix
branch
3 times, most recently
from
1144db3 to
8a26a6f
Compare
Check against platform and package specific version numbers returned from pkgs.tailscale.com instead of defaulting to "Version" as this can be incorrect for certain platforms when a release has only been built for a subset of platforms. For example. 1.90.2 is available for linux at the time of writing so "Version" is 1.90.2, but only 1.90.1 is available for windows which causes an error when using latest as the version specifier on windows machines. Fixes #219 Signed-off-by: Mario Minardi <mario@tailscale.com>
mpminardi
force-pushed
the
mpminardi/latest-fix
branch
from
8a26a6f to
bf5cb7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check against platform and package specific version numbers returned from pkgs.tailscale.com instead of defaulting to "Version" as this can be incorrect for certain platforms when a release has only been built for a subset of platforms.
For example. 1.90.2 is available for linux at the time of writing so "Version" is 1.90.2, but only 1.90.1 is available for windows which causes an error when using latest as the version specifier on windows machines.
Fixes #219