{action.yml,.github}: add support for windows #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccmtaylor
reviewed
Feb 25, 2025
action.yml
Outdated
| if [ "{{ runner.os }}" == "Linux" ]; then | ||
| HOSTNAME="github-$(cat /etc/hostname)" | ||
| elif [ "{{ runner.os }}" == "Windows" ]; then | ||
| HOSTNAME="github-$COMPUTERNAME" | ||
| fi |
There was a problem hiding this comment.
missing $s in front of the braces
Suggested change
| if [ "{{ runner.os }}" == "Linux" ]; then | |
| HOSTNAME="github-$(cat /etc/hostname)" | |
| elif [ "{{ runner.os }}" == "Windows" ]; then | |
| HOSTNAME="github-$COMPUTERNAME" | |
| fi | |
| if [ "${{ runner.os }}" == "Linux" ]; then | |
| HOSTNAME="github-$(cat /etc/hostname)" | |
| elif [ "${{ runner.os }}" == "Windows" ]; then | |
| HOSTNAME="github-$COMPUTERNAME" | |
| fi |
Member
Author
There was a problem hiding this comment.
Ah thanks, good catch!
mpminardi
force-pushed
the
mpminardi/windows-support
branch
from
07c60d3 to
c29cd81
Compare
dblohm7
requested changes
Feb 26, 2025
action.yml
Outdated
| VERSION=$(curl -s "https://pkgs.tailscale.com/stable/?mode=json" | jq -r .Version) | ||
| echo "Latest Tailscale version: $VERSION" | ||
| fi | ||
| if [ X64 = "ARM64" ]; then |
Member
There was a problem hiding this comment.
What is this X64 variable? Shouldn't it be runner.arch?
Member
Author
There was a problem hiding this comment.
Oh yup definitely should be, will fix.
mpminardi
force-pushed
the
mpminardi/windows-support
branch
from
c29cd81 to
5be1273
Compare
oxtoacart
approved these changes
Mar 3, 2025
Collaborator
oxtoacart
left a comment
oxtoacart
left a comment
There was a problem hiding this comment.
LGTM, just a couple of nitpicky suggestions.
action.yml
Outdated
| TS_ARCH="arm64" | ||
| elif [ ${{ runner.arch }} = "X86" ]; then | ||
| TS_ARCH="x86" | ||
| elif [ ${{ runner.arch }} = "X64" ]; then |
Collaborator
There was a problem hiding this comment.
nit: given the below else, you could skip this one.
action.yml
Outdated
| SHA256SUM: ${{ inputs.sha256sum }} | ||
| run: | | ||
| if [ "$VERSION" = "latest" ]; then | ||
| VERSION=$(curl -s "https://pkgs.tailscale.com/stable/?mode=json" | jq -r .Version) |
Collaborator
There was a problem hiding this comment.
I noticed you used -H user-agent:tailscale-github-action in a curl further down. Want to do it here too?
| URL="https://pkgs.tailscale.com/unstable/tailscale-setup-${VERSION}-${TS_ARCH}.msi" | ||
| fi | ||
| echo "Downloading $URL" | ||
| curl -H user-agent:tailscale-github-action -L "$URL" -o tailscale.msi --max-time 300 --fail |
Collaborator
There was a problem hiding this comment.
I like the custom user-agent here!
Add support for running the action on windows-based GitHub runners. Updates #157
mpminardi
force-pushed
the
mpminardi/windows-support
branch
from
5be1273 to
5dddea1
Compare
dblohm7
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for running the action on windows-based GitHub runners.
Updates #157