@@ -515,7 +515,7 @@ impl<'parser, 'refer, T> Ref<'parser, 'refer, T> {
515
515
{
516
516
{
517
517
let var = & mut self . parser . vars [ self . varid ] ;
518
- if var. metavar . len ( ) == 0 {
518
+ if var. metavar . is_empty ( ) {
519
519
let mut longest_name = names[ 0 ] ;
520
520
let mut llen = longest_name. len ( ) ;
521
521
for name in names. iter ( ) {
@@ -565,7 +565,7 @@ impl<'parser, 'refer, T> Ref<'parser, 'refer, T> {
565
565
}
566
566
{
567
567
let var = & mut self . parser . vars [ self . varid ] ;
568
- if var. metavar . len ( ) == 0 {
568
+ if var. metavar . is_empty ( ) {
569
569
var. metavar = name. to_string ( ) ;
570
570
}
571
571
}
@@ -691,7 +691,7 @@ impl<'parser> ArgumentParser<'parser> {
691
691
action : action,
692
692
} ) ;
693
693
694
- if names. len ( ) < 1 {
694
+ if names. is_empty ( ) {
695
695
panic ! ( "At least one name for option must be specified" ) ;
696
696
}
697
697
for nameptr in names. iter ( ) {
@@ -740,7 +740,7 @@ impl<'parser> ArgumentParser<'parser> {
740
740
stdout : & mut Write , stderr : & mut Write )
741
741
-> Result < ( ) , i32 >
742
742
{
743
- let name = if args. len ( ) > 0 { & args[ 0 ] [ ..] } else { "unknown" } ;
743
+ let name = if ! args. is_empty ( ) { & args[ 0 ] [ ..] } else { "unknown" } ;
744
744
match Context :: parse ( self , & args, stderr) {
745
745
Parsed => return Ok ( ( ) ) ,
746
746
Exit => return Err ( 0 ) ,
@@ -892,11 +892,11 @@ impl<'a, 'b> HelpFormatter<'a, 'b> {
892
892
fn write_help ( & mut self ) -> IoResult < ( ) > {
893
893
try!( self . write_usage ( ) ) ;
894
894
try!( write ! ( self . buf, "\n " ) ) ;
895
- if self . parser . description . len ( ) > 0 {
895
+ if ! self . parser . description . is_empty ( ) {
896
896
try!( wrap_text ( self . buf , self . parser . description , TOTAL_WIDTH , 0 ) ) ;
897
897
try!( write ! ( self . buf, "\n " ) ) ;
898
898
}
899
- if self . parser . arguments . len ( ) > 0
899
+ if ! self . parser . arguments . is_empty ( )
900
900
|| self . parser . catchall_argument . is_some ( )
901
901
{
902
902
try!( write ! ( self . buf, "\n Positional arguments:\n " ) ) ;
@@ -910,8 +910,8 @@ impl<'a, 'b> HelpFormatter<'a, 'b> {
910
910
None => { }
911
911
}
912
912
}
913
- if self . parser . short_options . len ( ) > 0
914
- || self . parser . long_options . len ( ) > 0
913
+ if ! self . parser . short_options . is_empty ( )
914
+ || ! self . parser . long_options . is_empty ( )
915
915
{
916
916
try!( write ! ( self . buf, "\n Optional arguments:\n " ) ) ;
917
917
for opt in self . parser . options . iter ( ) {
@@ -924,7 +924,7 @@ impl<'a, 'b> HelpFormatter<'a, 'b> {
924
924
fn write_usage ( & mut self ) -> IoResult < ( ) > {
925
925
try!( write ! ( self . buf, "Usage:\n " ) ) ;
926
926
try!( write ! ( self . buf, "{}" , self . name) ) ;
927
- if self . parser . options . len ( ) != 0 {
927
+ if ! self . parser . options . is_empty ( ) {
928
928
if self . parser . short_options . len ( ) > 1
929
929
|| self . parser . long_options . len ( ) > 1
930
930
{
0 commit comments