Skip to content

Commit 15de102

Browse files
committed
Fix clippy reported problems of len_zero lint
This change fixes occurrences flagged by the clippy lint `len_zero`. E.g., > warning: length comparison to one > --> src/parser.rs:694:12 > | > 694 | if names.len() < 1 { > | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `names.is_empty()` > | > = help: for further information visit > https://rust-lang-nursery.github.io/rust-clippy/master/index.html#len_zero
1 parent 433b566 commit 15de102

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

src/parser.rs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -515,7 +515,7 @@ impl<'parser, 'refer, T> Ref<'parser, 'refer, T> {
515515
{
516516
{
517517
let var = &mut self.parser.vars[self.varid];
518-
if var.metavar.len() == 0 {
518+
if var.metavar.is_empty() {
519519
let mut longest_name = names[0];
520520
let mut llen = longest_name.len();
521521
for name in names.iter() {
@@ -565,7 +565,7 @@ impl<'parser, 'refer, T> Ref<'parser, 'refer, T> {
565565
}
566566
{
567567
let var = &mut self.parser.vars[self.varid];
568-
if var.metavar.len() == 0 {
568+
if var.metavar.is_empty() {
569569
var.metavar = name.to_string();
570570
}
571571
}
@@ -691,7 +691,7 @@ impl<'parser> ArgumentParser<'parser> {
691691
action: action,
692692
});
693693

694-
if names.len() < 1 {
694+
if names.is_empty() {
695695
panic!("At least one name for option must be specified");
696696
}
697697
for nameptr in names.iter() {
@@ -740,7 +740,7 @@ impl<'parser> ArgumentParser<'parser> {
740740
stdout: &mut Write, stderr: &mut Write)
741741
-> Result<(), i32>
742742
{
743-
let name = if args.len() > 0 { &args[0][..] } else { "unknown" };
743+
let name = if !args.is_empty() { &args[0][..] } else { "unknown" };
744744
match Context::parse(self, &args, stderr) {
745745
Parsed => return Ok(()),
746746
Exit => return Err(0),
@@ -892,11 +892,11 @@ impl<'a, 'b> HelpFormatter<'a, 'b> {
892892
fn write_help(&mut self) -> IoResult<()> {
893893
try!(self.write_usage());
894894
try!(write!(self.buf, "\n"));
895-
if self.parser.description.len() > 0 {
895+
if !self.parser.description.is_empty() {
896896
try!(wrap_text(self.buf, self.parser.description,TOTAL_WIDTH, 0));
897897
try!(write!(self.buf, "\n"));
898898
}
899-
if self.parser.arguments.len() > 0
899+
if !self.parser.arguments.is_empty()
900900
|| self.parser.catchall_argument.is_some()
901901
{
902902
try!(write!(self.buf, "\nPositional arguments:\n"));
@@ -910,8 +910,8 @@ impl<'a, 'b> HelpFormatter<'a, 'b> {
910910
None => {}
911911
}
912912
}
913-
if self.parser.short_options.len() > 0
914-
|| self.parser.long_options.len() > 0
913+
if !self.parser.short_options.is_empty()
914+
|| !self.parser.long_options.is_empty()
915915
{
916916
try!(write!(self.buf, "\nOptional arguments:\n"));
917917
for opt in self.parser.options.iter() {
@@ -924,7 +924,7 @@ impl<'a, 'b> HelpFormatter<'a, 'b> {
924924
fn write_usage(&mut self) -> IoResult<()> {
925925
try!(write!(self.buf, "Usage:\n "));
926926
try!(write!(self.buf, "{}", self.name));
927-
if self.parser.options.len() != 0 {
927+
if !self.parser.options.is_empty() {
928928
if self.parser.short_options.len() > 1
929929
|| self.parser.long_options.len() > 1
930930
{

0 commit comments

Comments
 (0)