Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: arm-linux-gnueabihf-strip not found, skip stripping #59

Closed
VorpalBlade opened this issue Oct 30, 2023 · 5 comments · Fixed by #66
Closed

Warning: arm-linux-gnueabihf-strip not found, skip stripping #59

VorpalBlade opened this issue Oct 30, 2023 · 5 comments · Fixed by #66
Labels
question Further information is requested

Comments

@VorpalBlade
Copy link

When running release jobs using this action and cross compiling to Linuxes that are not x86-64 or i686 I get the following warnings in the builds:

upload-assets (aarch64-unknown-linux-musl, ubuntu-latest)
aarch64-linux-gnu-strip not found, skip stripping

upload-assets (armv7-unknown-linux-musleabihf, ubuntu-latest)
arm-linux-gnueabihf-strip not found, skip stripping

upload-assets (aarch64-unknown-linux-gnu, ubuntu-latest)
aarch64-linux-gnu-strip not found, skip stripping

upload-assets (armv7-unknown-linux-gnueabihf, ubuntu-latest)
arm-linux-gnueabihf-strip not found, skip stripping

Here is an example run of this: https://github.com/VorpalBlade/chezmoi_modify_manager/actions/runs/6699435637
And the relevant workflow: https://github.com/VorpalBlade/chezmoi_modify_manager/blob/main/.github/workflows/release.yml (specifically the job upload-assets).

Am I doing something wrong? Or is it a bug in the action whereby it doesn't install some required dependency? I seem to be doing the same things you do in your examples in your README though.

@taiki-e
Copy link
Owner

taiki-e commented Dec 28, 2023

This is normal behavior. We originally used strip on all targets, but found that the strip installed by default on the runner did not work on some targets (#8), so we changed the strip on those targets to not strip if the tool is not installed.

This warning is a note to users who expect strip to work by default on all targets, and if you actually want strip to work on all targets, you will need a cargo profile as documented. (Or, you should also not get this warning if you are using another cross-compilation way.)

This action was created before the strip in cargo profile was stabilized, so it required a strip on our part, but now that the the strip in cargo profile has been stable for some time, it may be appropriate to remove the strip on our part completely in favor of recommend using the strip in cargo profile. I plan to make that change, at least in v2.

@taiki-e taiki-e added the question Further information is requested label Dec 28, 2023
@taiki-e
Copy link
Owner

taiki-e commented Feb 21, 2024

strip will be the default in the next stable (1.77, rust-lang/cargo#13257), so when that is released, strip on our part will be removed and this warning will be removed at the same time.

@VorpalBlade
Copy link
Author

@taiki-e Hm, it would be great if we could actually do split debug info and upload that as well somewhere. Not being able to debug released binaries isn't great (though far less of a problem in Rust than C++ of course, but not all projects only depend on pure rust code)

@taiki-e
Copy link
Owner

taiki-e commented Feb 21, 2024

@taiki-e
Copy link
Owner

taiki-e commented Feb 21, 2024

There was a suggestion regarding supporting split debuginfo as an option for this action (#49), but perhaps another approach should be considered once Cargo enables strip by default. Although, we could do that while controlling Cargo's strip settings via environment variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants