Add dry-run-intended to suppress informational warnings generated by dry-run (#100)

Author: eirnym

README.md

@@ -55,6 +55,7 @@ Currently, this action is basically intended to be used in combination with an a
 | manifest-path       |           | Path to Cargo.toml                                                                           | String  | `Cargo.toml`   |
 | profile             |           | The cargo profile to build. This defaults to the release profile.                            | String  | `release`      |
 | dry-run             |           | Build and compress binaries, but do not upload them (see [action.yml](action.yml) for more)  | Boolean | `false`        |
+| dry-run-intended    |           | Suppress informational `dry-run` warnings, keeping the rest                                  | Boolean | `false`        |
 | codesign            |           | Sign build products using `codesign` on macOS                                                | String  |                |
 | codesign-prefix     |           | Prefix for the `codesign` identifier on macOS                                                | String  |                |
 | codesign-options    |           | Specifies a set of option flags to be embedded in the code signature on macOS. See the `codesign` manpage for details. | String | |

action.yml

@@ -97,6 +97,11 @@ inputs:
 
       Note that some errors are downgraded to warnings in this mode.
     required: false
+  dry-run-intended:
+    description: >
+      Suppress informational warnings for `dru-run` keeping the rest
+    required: false
+    default: 'false'
   dry_run:
     description: Alias for 'dry-run'
     required: false
@@ -176,6 +181,7 @@ runs:
         INPUT_REF: ${{ inputs.ref }}
         INPUT_PROFILE: ${{ inputs.profile }}
         INPUT_DRY_RUN: ${{ inputs.dry-run || inputs.dry_run }}
+        INPUT_DRY_RUN_INTENDED: ${{ inputs.dry-run-intended }}
         INPUT_CODESIGN: ${{ inputs.codesign }}
         INPUT_CODESIGN_PREFIX: ${{ inputs.codesign-prefix || inputs.codesign_prefix }}
         INPUT_CODESIGN_OPTIONS: ${{ inputs.codesign-options || inputs.codesign_options }}

main.sh

@@ -44,24 +44,36 @@ case "${dry_run}" in
   *) bail "'dry-run' input option must be 'true' or 'false': '${dry_run}'" ;;
 esac
 
+dry_run_intended="${INPUT_DRY_RUN_INTENDED:-}"
+case "${dry_run_intended}" in
+  true) dry_run_intended=1 ;;
+  false) dry_run_intended='' ;;
+  '') dry_run_intended='' ;;
+  *) bail "'dry-run-intended' input option must be 'true' or 'false': '${dry_run_intended}'" ;;
+esac
+
 token="${INPUT_TOKEN:-"${GITHUB_TOKEN:-}"}"
 ref="${INPUT_REF:-"${GITHUB_REF:-}"}"
 
 if [[ -z "${token}" ]]; then
   if [[ -n "${dry_run}" ]]; then
-    # TODO: The warnings are somewhat noisy if we have a lot of build matrix:
-    # https://github.com/taiki-e/upload-rust-binary-action/pull/55#discussion_r1349880455
-    warn "neither GITHUB_TOKEN environment variable nor 'token' input option is set (downgraded error to info because action is running in dry-run mode)"
+    if [[ -z "${dry_run_intended}" ]]; then
+      # TODO: The warnings are somewhat noisy if we have a lot of build matrix:
+      # https://github.com/taiki-e/upload-rust-binary-action/pull/55#discussion_r1349880455
+      warn "neither GITHUB_TOKEN environment variable nor 'token' input option is set (downgraded error to info because action is running in dry-run mode)"
+    fi
   else
     bail "neither GITHUB_TOKEN environment variable nor 'token' input option is set"
   fi
 fi
 
 if [[ "${ref}" != "refs/tags/"* ]]; then
   if [[ -n "${dry_run}" ]]; then
-    # TODO: The warnings are somewhat noisy if we have a lot of build matrix:
-    # https://github.com/taiki-e/upload-rust-binary-action/pull/55#discussion_r1349880455
-    warn "tag ref should start with 'refs/tags/': '${ref}'; this action only supports events from tag or release by default; see <https://github.com/taiki-e/create-gh-release-action#supported-events> for more (downgraded error to info because action is running in dry-run mode)"
+    if [[ -z "${dry_run_intended}" ]]; then
+      # TODO: The warnings are somewhat noisy if we have a lot of build matrix:
+      # https://github.com/taiki-e/upload-rust-binary-action/pull/55#discussion_r1349880455
+      warn "tag ref should start with 'refs/tags/': '${ref}'; this action only supports events from tag or release by default; see <https://github.com/taiki-e/create-gh-release-action#supported-events> for more (downgraded error to info because action is running in dry-run mode)"
+    fi
     ref='refs/tags/dry-run'
   else
     bail "tag ref should start with 'refs/tags/': '${ref}'; this action only supports events from tag or release by default; see <https://github.com/taiki-e/create-gh-release-action#supported-events> for more"
@@ -562,8 +574,10 @@ for checksum in ${checksums[@]+"${checksums[@]}"}; do
 done
 
 if [[ -n "${dry_run}" ]]; then
-  info "skipped upload because action is running in dry-run mode"
-  printf "tag: %s ('dry-run' if tag ref is not start with 'refs/tags/')\n" "${tag}"
+  if [[ -z "${dry_run_intended}" ]]; then
+    info "skipped upload because action is running in dry-run mode"
+    printf "tag: %s ('dry-run' if tag ref is not start with 'refs/tags/')\n" "${tag}"
+  fi
   IFS=','
   printf 'assets: %s\n' "${final_assets[*]}"
   IFS=$'\n\t'