Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to composite action #58

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Switch to composite action #58

merged 1 commit into from
Feb 22, 2023

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Jan 16, 2023

This switching is needed to implement the idea said in #54 (comment). (To actually do it, we also need to address the cache-cargo-install-action's limitation that cannot specify multiple crates in a single action call, though.)

Ideally, I would like to merge cache-cargo-install-action into install-action, run cargo-binstall with --disable-strategies compile, and use cache-cargo-install-action when the installation fails, though...

I tried this twice in the past and gave up due to actions/runner#665 and actions/runner#2185, respectively, and eventually was able to work around these problems when implementing cache-cargo-install-action.

@taiki-e
Copy link
Owner Author

taiki-e commented Jan 16, 2023

A potential concern regarding this is compatibility with older self-hosted runners.

Composite action was added on 2020-08-07, but it probably requires 2.290.0 (2022-04-13) or 2.295.0 (2022-08-10) for this action to actually work properly in the composite action on the self-hosted runners.

@taiki-e taiki-e mentioned this pull request Feb 8, 2023
2 tasks
@taiki-e
Copy link
Owner Author

taiki-e commented Feb 22, 2023

Given that it has been 6 months since the release of runner, which is expected to work, and that node 16 will be EoL in about 6 more months, I think this is a reasonable time to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant