Fix Attribute::unescape_value does not unescape predefined entities since #739

Mingun · Mingun · commit 0315ed0a479d · 2024-06-28T18:39:20.000+05:00
diff --git a/Changelog.md b/Changelog.md
@@ -26,6 +26,7 @@
   As a result, the following variants of `quick_xml::escape::EscapeError` are removed:
   - `TooLongDecimal`
   - `TooLongHexadecimal`
+- [#771]: Fixed `Attribute::unescape_value` which does not unescape predefined values since 0.32.0.
 
 ### Misc Changes
 
diff --git a/src/events/attributes.rs b/src/events/attributes.rs
@@ -45,7 +45,7 @@ impl<'a> Attribute<'a> {
     /// [`encoding`]: ../../index.html#encoding
     #[cfg(any(doc, not(feature = "encoding")))]
     pub fn unescape_value(&self) -> XmlResult<Cow<'a, str>> {
-        self.unescape_value_with(|_| None)
+        self.unescape_value_with(resolve_predefined_entity)
     }
 
     /// Decodes using UTF-8 then unescapes the value, using custom entities.

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ impl<'a> Attribute<'a> {`
`45`	`45`	/// [`encoding`]: ../../index.html#encoding
`46`	`46`	`#[cfg(any(doc, not(feature = "encoding")))]`
`47`	`47`	`pub fn unescape_value(&self) -> XmlResult<Cow<'a, str>> {`
`48`		`- self.unescape_value_with(\|_\| None)`
	`48`	`+ self.unescape_value_with(resolve_predefined_entity)`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`/// Decodes using UTF-8 then unescapes the value, using custom entities.`