refactor(oxlint): pass DiagnosticService as a parameter for TsGoLintState.lint() (oxc-project#13004)

Started to refactor for the language server, but noticed it needs more to be done: oxc-project/tsgolint#71
Still opened the PR to align with the service:

https://github.com/oxc-project/oxc/blob/ca91a261556d88cde7ece4314d905a78aca1cc76/crates/oxc_linter/src/service/mod.rs#L91-L102

Author: Sysix

apps/oxlint/src/lint.rs

@@ -307,8 +307,8 @@ impl LintRunner {
         if let Some(ret) = self
             .options
             .type_aware
-            .then(|| TsGoLintState::new(tx_error.clone(), config_store.clone(), &paths, &options))
-            .and_then(|s| s.lint(stdout))
+            .then(|| TsGoLintState::new(config_store.clone(), &paths, &options))
+            .and_then(|s| s.lint(tx_error.clone(), stdout))
         {
             return ret;
         }

apps/oxlint/src/tsgolint.rs

@@ -29,19 +29,15 @@ pub struct TsGoLintState<'a> {
     paths: &'a Vec<Arc<OsStr>>,
     /// The configuration store for `tsgolint` (used to resolve configurations outside of `oxc_linter`)
     config_store: ConfigStore,
-    /// Channel to send errors from `tsgolint` to the main thread
-    error_sender: DiagnosticSender,
 }
 
 impl<'a> TsGoLintState<'a> {
     pub fn new(
-        error_sender: DiagnosticSender,
         config_store: ConfigStore,
         paths: &'a Vec<Arc<OsStr>>,
         options: &LintServiceOptions,
     ) -> Self {
         TsGoLintState {
-            error_sender,
             config_store,
             executable_path: try_find_tsgolint_executable(options.cwd())
                 .unwrap_or(PathBuf::from("tsgolint")),
@@ -50,7 +46,11 @@ impl<'a> TsGoLintState<'a> {
         }
     }
 
-    pub fn lint(self, stdout: &mut dyn Write) -> Option<CliRunResult> {
+    pub fn lint(
+        self,
+        error_sender: DiagnosticSender,
+        stdout: &mut dyn Write,
+    ) -> Option<CliRunResult> {
         if self.paths.is_empty() {
             return None;
         }
@@ -172,7 +172,7 @@ impl<'a> TsGoLintState<'a> {
                             &read_to_string(&file_path).unwrap_or_else(|_| String::new()),
                             diagnostics,
                         );
-                        self.error_sender
+                        error_sender
                             .send((file_path.clone(), diagnostics))
                             .expect("Failed to send diagnostic");
                     }