Skip to content

Commit aa9639f

Browse files
committed
workaround for github actions being completely unusable garbage
1 parent e261b5e commit aa9639f

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

.github/workflows/ci.yml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,3 +65,19 @@ jobs:
6565
run: ./pw uv run cargo fmt --all --check
6666
- name: Check Rust
6767
run: ./pw uv run cargo check
68+
69+
# for some insane reason it's impossible to configure github actions to require that all checks pass before merging.
70+
# you have to create a rule eith every single job in your ci, and remember to manually update that rule when they change.
71+
# so instead we need this job at the end that checks the status of all the previous jobs so we don't need to constantly
72+
# worry about keeping the rule up to date.
73+
all-checks:
74+
runs-on: ubuntu-latest
75+
needs: build
76+
if: always()
77+
steps:
78+
- name: Check previous job results
79+
run: |
80+
if [ "${{ needs.build.result }}" != "success" ]; then
81+
echo "previous jobs failed"
82+
exit 1
83+
fi

0 commit comments

Comments
 (0)