Encapsulate the method's of rulings from class Page#514
Open
ShienF wants to merge 1 commit intotabulapdf:masterfrom
Open
Encapsulate the method's of rulings from class Page#514ShienF wants to merge 1 commit intotabulapdf:masterfrom
ShienF wants to merge 1 commit intotabulapdf:masterfrom
Conversation
Encapsulate rulings method from class Page into class Rulings. Make these methods more OO.
Member
|
I like this. What do you think @jazzido ? I'd like to do a little bit of clean-up (e.g. erasing the TODO comment on L26 that's solved by this PR.) but otherwise very into it. Noting that I haven't actually run the tests with this patch; don't have a dev env set up on this particular laptop. |
Member
|
and @ShienF thanks very much for the PR and sorry for the wait |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encapsulate rulings method from class Page into class Rulings. Make methods about rullings more object-oriented.