Skip to content

BYO iframe #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BYO iframe #1

wants to merge 1 commit into from

Conversation

@olizilla
Copy link
Member

@olizilla olizilla commented Jan 24, 2017

As per @richsilv's good idea, this PR refactors things to let caller pass in an iframe or other responsively embeddable thing.

Usage would now look like:

<ResponsiveEmbed ratio='4:3'>
  <iframe src='https://www.youtube.com/embed/2yqz9zgoC-U' allowfullscreen />
</ResponsiveEmbed>

if no ratio is provided then 16:9 is assumed

@olizilla olizilla mentioned this pull request Sep 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@olizilla