Skip to content

Commit d4c2645

Browse files
committed
Remove old reference to setup.py
1 parent 44e0759 commit d4c2645

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

docs/dev-guide.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ add your contributions to the **development** branch.
4343
git remote add upstream https://github.com/tableau/server-client-python
4444
```
4545
More information about configuring a remote for a fork can be found [here](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/configuring-a-remote-for-a-fork).
46-
4746
1. Sync your fork:
47+
4848
```shell
4949
git fetch upstream
5050
```
@@ -135,17 +135,17 @@ depending on how and where git is installed on your system, for example:
135135
1. Add type hints to all new classes and functions added. Including type hinting
136136
on unit tests.
137137

138-
2. Add a sample to show users how to use the new feature. Try to keep the command
138+
1. Add a sample to show users how to use the new feature. Try to keep the command
139139
line arguments of your sample consistent with the [Samples documentation page](samples)
140140
and with other samples.
141141

142-
3. Add documentation (most likely in api-ref.md) in a separate pull request
142+
1. Add documentation (most likely in api-ref.md) in a separate pull request
143143
(see more below).
144144

145145
### Add tests
146146

147147
All of our tests live under the `test/` folder in the repository. We use
148-
`pytest` and the built-in test runner `python setup.py test`.
148+
`pytest` which is run with `pytest test`.
149149

150150
Follow the structure of existing tests, especially if new server responses
151151
are going to be mocked.
@@ -225,7 +225,7 @@ follow these steps:
225225
1. (Optional) Do a test publish to PyPI without creating the next version tag.
226226
This will create a pre-release package with a version like `0.30.post0.dev`.
227227

228-
1. On a local clone of the repo, create and push the tag for the *next* version
228+
1. On a local clone of the repo, create and push the tag for the _next_ version
229229
(in this example it's "v0.31"):
230230

231231
```shell

0 commit comments

Comments
 (0)