Skip to content

Commit b0e9255

Browse files
committed
DRY range definitions
1 parent 64a6077 commit b0e9255

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

tableauserverclient/server/query.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ def __getitem__(self, k):
3333
page = self.page_number
3434
size = self.page_size
3535

36+
page_range = range((page - 1) * size, page*size)
37+
3638
if isinstance(k, slice):
3739
step = k.step if k.step is not None else 1
3840
start = k.start if k.start is not None else 0
@@ -41,14 +43,16 @@ def __getitem__(self, k):
4143
start += self.total_available
4244
if stop < 0:
4345
stop += self.total_available
44-
if all(i in range((page - 1) * size, page*size) for i in range(start, stop, step)):
46+
47+
k_range = range(start, stop, step)
48+
if all(i in page_range for i in k_range):
4549
return self._result_cache[k]
46-
return [self[i] for i in range(start, stop, step)]
50+
return [self[i] for i in k_range]
4751

4852
if k < 0:
4953
k += self.total_available
5054

51-
if k in range((page - 1) * size, page*size):
55+
if k in page_range:
5256
return self._result_cache[k % size]
5357
elif k in range(self.total_available):
5458
self._result_cache = None

0 commit comments

Comments
 (0)