Skip to content

Commit 77ef628

Browse files
committed
Jac/createextracts bug (#1026)
fix xml generation for items
1 parent b6fd634 commit 77ef628

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

tableauserverclient/server/request_factory.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -887,7 +887,6 @@ def _generate_xml(
887887
views_element = ET.SubElement(workbook_element, "views")
888888
for view_name in workbook_item.hidden_views:
889889
_add_hiddenview_element(views_element, view_name)
890-
891890
return ET.tostring(xml_request)
892891

893892
def update_req(self, workbook_item):
@@ -960,9 +959,9 @@ def embedded_extract_req(self, xml_request, include_all=True, datasources=None):
960959
list_element = ET.SubElement(xml_request, "datasources")
961960
if include_all:
962961
list_element.attrib["includeAll"] = "true"
963-
else:
962+
elif datasources:
964963
for datasource_item in datasources:
965-
datasource_element = list_element.SubElement(xml_request, "datasource")
964+
datasource_element = ET.SubElement(list_element, "datasource")
966965
datasource_element.attrib["id"] = datasource_item.id
967966

968967

0 commit comments

Comments
 (0)