Skip to content

Commit 47eab0b

Browse files
authored
fix revision references where xml returned does not match docs (#1176)
* fix revision references where xml returned does not match docs
1 parent d9f64e1 commit 47eab0b

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

tableauserverclient/models/revision_item.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,10 @@ def from_response(cls, resp: bytes, ns, resource_item) -> List["RevisionItem"]:
6767
revision_item._resource_id = resource_item.id
6868
revision_item._resource_name = resource_item.name
6969
revision_item._revision_number = revision_xml.get("revisionNumber", None)
70-
revision_item._current = string_to_bool(revision_xml.get("isCurrent", ""))
71-
revision_item._deleted = string_to_bool(revision_xml.get("isDeleted", ""))
72-
revision_item._created_at = parse_datetime(revision_xml.get("createdAt", None))
73-
for user in revision_xml.findall(".//t:user", namespaces=ns):
70+
revision_item._current = string_to_bool(revision_xml.get("current", ""))
71+
revision_item._deleted = string_to_bool(revision_xml.get("deleted", ""))
72+
revision_item._created_at = parse_datetime(revision_xml.get("publishedAt", None))
73+
for user in revision_xml.findall(".//t:publisher", namespaces=ns):
7474
revision_item._user_id = user.get("id", None)
7575
revision_item._user_name = user.get("name", None)
7676

test/assets/datasource_revision.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22
<tsResponse xmlns="http://tableau.com/api" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://tableau.com/api http://tableau.com/api/ts-api-2.3.xsd">
33
<pagination pageNumber="1" pageSize="100" totalAvailable="3" />
44
<revisions>
5-
<revision createdAt="2016-07-26T20:34:56Z" revisionNumber="1" isDeleted="false">
6-
<user id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
5+
<revision publishedAt="2016-07-26T20:34:56Z" revisionNumber="1" deleted="false">
6+
<publisher id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
77
</revision>
8-
<revision createdAt="2016-07-27T20:34:56Z" revisionNumber="2" isDeleted="false">
8+
<revision publishedAt="2016-07-27T20:34:56Z" revisionNumber="2" deleted="false">
99
</revision>
10-
<revision createdAt="2016-07-28T20:34:56Z" revisionNumber="3" isCurrent="true">
11-
<user id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
10+
<revision publishedAt="2016-07-28T20:34:56Z" revisionNumber="3" current="true">
11+
<publisher id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
1212
</revision>
1313
</revisions>
1414
</tsResponse>

test/assets/workbook_revision.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22
<tsResponse xmlns="http://tableau.com/api" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://tableau.com/api http://tableau.com/api/ts-api-2.3.xsd">
33
<pagination pageNumber="1" pageSize="100" totalAvailable="3" />
44
<revisions>
5-
<revision createdAt="2016-07-26T20:34:56Z" revisionNumber="1" isDeleted="false">
6-
<user id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
5+
<revision publishedAt="2016-07-26T20:34:56Z" revisionNumber="1" deleted="false">
6+
<publisher id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
77
</revision>
8-
<revision createdAt="2016-07-27T20:34:56Z" revisionNumber="2" isDeleted="false">
8+
<revision publishedAt="2016-07-27T20:34:56Z" revisionNumber="2" deleted="false">
99
</revision>
10-
<revision createdAt="2016-07-28T20:34:56Z" revisionNumber="3" isCurrent="true">
11-
<user id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
10+
<revision publishedAt="2016-07-28T20:34:56Z" revisionNumber="3" current="true">
11+
<publisher id="5de011f8-5aa9-4d5b-b991-f462c8dd6bb7" name="Cassie"/>
1212
</revision>
1313
</revisions>
1414
</tsResponse>

0 commit comments

Comments
 (0)