Skip to content

Commit 17a7443

Browse files
committed
chore: switch to pytest style asserts
1 parent 23729ae commit 17a7443

File tree

1 file changed

+28
-26
lines changed

1 file changed

+28
-26
lines changed

test/test_linked_tasks.py

Lines changed: 28 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -27,47 +27,49 @@ def setUp(self) -> None:
2727
def test_parse_linked_task_flow_run(self):
2828
xml = fromstring(GET_LINKED_TASKS.read_bytes())
2929
task_runs = LinkedTaskFlowRunItem._parse_element(xml, self.server.namespace)
30-
self.assertEqual(1, len(task_runs))
30+
assert 1 == len(task_runs)
3131
task = task_runs[0]
32-
self.assertEqual(task.flow_run_id, "e3d1fc25-5644-4e32-af35-58dcbd1dbd73")
33-
self.assertEqual(task.flow_run_priority, 1)
34-
self.assertEqual(task.flow_run_consecutive_failed_count, 3)
35-
self.assertEqual(task.flow_run_task_type, "runFlow")
36-
self.assertEqual(task.flow_id, "ab1231eb-b8ca-461e-a131-83f3c2b6a673")
37-
self.assertEqual(task.flow_name, "flow-name")
32+
assert task.flow_run_id == "e3d1fc25-5644-4e32-af35-58dcbd1dbd73"
33+
assert task.flow_run_priority == 1
34+
assert task.flow_run_consecutive_failed_count == 3
35+
assert task.flow_run_task_type == "runFlow"
36+
assert task.flow_id == "ab1231eb-b8ca-461e-a131-83f3c2b6a673"
37+
assert task.flow_name == "flow-name"
3838

3939
def test_parse_linked_task_step(self):
4040
xml = fromstring(GET_LINKED_TASKS.read_bytes())
4141
steps = LinkedTaskStepItem.from_task_xml(xml, self.server.namespace)
42-
self.assertEqual(1, len(steps))
42+
assert 1 == len(steps)
4343
step = steps[0]
44-
self.assertEqual(step.id, "f554a4df-bb6f-4294-94ee-9a709ef9bda0")
45-
self.assertTrue(step.stop_downstream_on_failure)
46-
self.assertEqual(step.step_number, 1)
47-
self.assertEqual(1, len(step.task_details))
44+
assert step.id == "f554a4df-bb6f-4294-94ee-9a709ef9bda0"
45+
assert step.stop_downstream_on_failure
46+
assert step.step_number == 1
47+
assert 1 == len(step.task_details)
4848
task = step.task_details[0]
49-
self.assertEqual(task.flow_run_id, "e3d1fc25-5644-4e32-af35-58dcbd1dbd73")
50-
self.assertEqual(task.flow_run_priority, 1)
51-
self.assertEqual(task.flow_run_consecutive_failed_count, 3)
52-
self.assertEqual(task.flow_run_task_type, "runFlow")
53-
self.assertEqual(task.flow_id, "ab1231eb-b8ca-461e-a131-83f3c2b6a673")
54-
self.assertEqual(task.flow_name, "flow-name")
49+
assert task.flow_run_id == "e3d1fc25-5644-4e32-af35-58dcbd1dbd73"
50+
assert task.flow_run_priority == 1
51+
assert task.flow_run_consecutive_failed_count == 3
52+
assert task.flow_run_task_type == "runFlow"
53+
assert task.flow_id == "ab1231eb-b8ca-461e-a131-83f3c2b6a673"
54+
assert task.flow_name == "flow-name"
5555

5656
def test_parse_linked_task(self):
5757
tasks = LinkedTaskItem.from_response(GET_LINKED_TASKS.read_bytes(), self.server.namespace)
58-
self.assertEqual(1, len(tasks))
58+
assert 1 == len(tasks)
5959
task = tasks[0]
60-
self.assertEqual(task.id, "1b8211dc-51a8-45ce-a831-b5921708e03e")
61-
self.assertEqual(task.num_steps, 1)
62-
self.assertEqual(task.schedule.id, "be077332-d01d-481b-b2f3-917e463d4dca")
60+
assert task.id == "1b8211dc-51a8-45ce-a831-b5921708e03e"
61+
assert task.num_steps == 1
62+
assert task.schedule is not None
63+
assert task.schedule.id == "be077332-d01d-481b-b2f3-917e463d4dca"
6364

6465
def test_get_linked_tasks(self):
6566
with requests_mock.mock() as m:
6667
m.get(self.baseurl, text=GET_LINKED_TASKS.read_text())
6768
tasks, pagination_item = self.server.linked_tasks.get()
6869

69-
self.assertEqual(1, len(tasks))
70+
assert 1 == len(tasks)
7071
task = tasks[0]
71-
self.assertEqual(task.id, "1b8211dc-51a8-45ce-a831-b5921708e03e")
72-
self.assertEqual(task.num_steps, 1)
73-
self.assertEqual(task.schedule.id, "be077332-d01d-481b-b2f3-917e463d4dca")
72+
assert task.id == "1b8211dc-51a8-45ce-a831-b5921708e03e"
73+
assert task.num_steps == 1
74+
assert task.schedule is not None
75+
assert task.schedule.id == "be077332-d01d-481b-b2f3-917e463d4dca"

0 commit comments

Comments
 (0)