Stop supporting Python 3.5

vogelsgesang · vogelsgesang · commit 168638c2d04d · 2021-10-07T14:48:45.000+02:00
Python 3.5 is already end-of-life and no longer receives security patches for over a year now.
Also, I recently added an f-string because all Python versions which are still in support, also
support f-strings. I was unpleasantly surprised when I had to realize that we still claim to
support Python 3.5 which doesn't have f-strings...
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -8,7 +8,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest, windows-latest]
-        python-version: [3.5, 3.6, 3.7, 3.8, 3.9, 3.10.0-rc.2]
+        python-version: [3.6, 3.7, 3.8, 3.9, 3.10.0-rc.2]
 
     runs-on: ${{ matrix.os }}
 
diff --git a/README.md b/README.md
@@ -8,7 +8,7 @@ Use the Tableau Server Client (TSC) library to increase your productivity as you
 * Create users and groups.
 * Query projects, sites, and more.
 
-This repository contains Python source code and sample files. Python versions 3.5 and up are supported.
+This repository contains Python source code and sample files. Python versions 3.6 and up are supported.
 
 For more information on installing and using TSC, see the documentation:
 <https://tableau.github.io/server-client-python/docs/>
diff --git a/samples/add_default_permission.py b/samples/add_default_permission.py
@@ -1,6 +1,6 @@
 ####
 # This script demonstrates how to add default permissions using TSC
-# To run the script, you must have installed Python 3.5 and later.
+# To run the script, you must have installed Python 3.6 or later.
 #
 # In order to demonstrate adding a new default permission, this sample will create
 # a new project and add a new capability to the new project, for the default "All users" group.
diff --git a/samples/create_group.py b/samples/create_group.py
@@ -2,7 +2,7 @@
 # This script demonstrates how to create a group using the Tableau
 # Server Client.
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 
diff --git a/samples/create_project.py b/samples/create_project.py
@@ -4,7 +4,7 @@
 # parent_id.
 #
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse
diff --git a/samples/create_schedules.py b/samples/create_schedules.py
@@ -2,7 +2,7 @@
 # This script demonstrates how to create schedules using the Tableau
 # Server Client.
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 
diff --git a/samples/download_view_image.py b/samples/download_view_image.py
@@ -5,7 +5,7 @@
 # For more information, refer to the documentations on 'Query View Image'
 # (https://onlinehelp.tableau.com/current/api/rest_api/en-us/help.htm)
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse
diff --git a/samples/export.py b/samples/export.py
@@ -2,7 +2,7 @@
 # This script demonstrates how to export a view using the Tableau
 # Server Client.
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse
diff --git a/samples/export_wb.py b/samples/export_wb.py
@@ -4,7 +4,7 @@
 #
 # You will need to do `pip install PyPDF2` to use this sample.
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 
diff --git a/samples/filter_sort_groups.py b/samples/filter_sort_groups.py
@@ -2,7 +2,7 @@
 # This script demonstrates how to filter and sort groups using the Tableau
 # Server Client.
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 
diff --git a/samples/filter_sort_projects.py b/samples/filter_sort_projects.py
@@ -2,7 +2,7 @@
 # This script demonstrates how to use the Tableau Server Client
 # to filter and sort on the name of the projects present on site.
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse
diff --git a/samples/kill_all_jobs.py b/samples/kill_all_jobs.py
@@ -1,7 +1,7 @@
 ####
 # This script demonstrates how to kill all of the running jobs
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse
diff --git a/samples/list.py b/samples/list.py
@@ -1,7 +1,7 @@
 ####
 # This script demonstrates how to list all of the workbooks or datasources
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse
diff --git a/samples/login.py b/samples/login.py
@@ -1,7 +1,7 @@
 ####
 # This script demonstrates how to log in to Tableau Server Client.
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse
diff --git a/samples/metadata_query.py b/samples/metadata_query.py
@@ -1,7 +1,7 @@
 ####
 # This script demonstrates how to use the metadata API to query information on a published data source
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse
diff --git a/samples/move_workbook_projects.py b/samples/move_workbook_projects.py
@@ -4,7 +4,7 @@
 # a workbook that matches a given name and update it to be in
 # the desired project.
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse
diff --git a/samples/move_workbook_sites.py b/samples/move_workbook_sites.py
@@ -4,7 +4,7 @@
 # a workbook that matches a given name, download the workbook,
 # and then publish it to the destination site.
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse
diff --git a/samples/publish_datasource.py b/samples/publish_datasource.py
@@ -15,7 +15,7 @@
 # more information on personal access tokens, refer to the documentations:
 # (https://help.tableau.com/current/server/en-us/security_personal_access_tokens.htm)
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse
diff --git a/samples/publish_workbook.py b/samples/publish_workbook.py
@@ -11,7 +11,7 @@
 # For more information, refer to the documentations on 'Publish Workbook'
 # (https://onlinehelp.tableau.com/current/api/rest_api/en-us/help.htm)
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse
diff --git a/samples/query_permissions.py b/samples/query_permissions.py
@@ -1,6 +1,6 @@
 ####
 # This script demonstrates how to query for permissions using TSC
-# To run the script, you must have installed Python 3.5 and later.
+# To run the script, you must have installed Python 3.6 or later.
 #
 # Example usage: 'python query_permissions.py -s https://10ax.online.tableau.com --site
 #       devSite123 -u tabby@tableau.com workbook b4065286-80f0-11ea-af1b-cb7191f48e45'
diff --git a/samples/refresh.py b/samples/refresh.py
@@ -1,7 +1,7 @@
 ####
 # This script demonstrates how to use trigger a refresh on a datasource or workbook
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse
diff --git a/samples/refresh_tasks.py b/samples/refresh_tasks.py
@@ -2,7 +2,7 @@
 # This script demonstrates how to use the Tableau Server Client
 # to query extract refresh tasks and run them as needed.
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse
diff --git a/samples/set_http_options.py b/samples/set_http_options.py
@@ -2,7 +2,7 @@
 # This script demonstrates how to set http options. It will set the option
 # to not verify SSL certificate, and query all workbooks on site.
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse
diff --git a/samples/set_refresh_schedule.py b/samples/set_refresh_schedule.py
@@ -2,7 +2,7 @@
 # This script demonstrates how to set the refresh schedule for
 # a workbook or datasource.
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 
diff --git a/samples/update_connection.py b/samples/update_connection.py
@@ -1,7 +1,7 @@
 ####
 # This script demonstrates how to update a connections credentials on a server to embed the credentials
 #
-# To run the script, you must have installed Python 3.5 or later.
+# To run the script, you must have installed Python 3.6 or later.
 ####
 
 import argparse

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`####`
`2`	`2`	`# This script demonstrates how to add default permissions using TSC`
`3`		`-# To run the script, you must have installed Python 3.5 and later.`
	`3`	`+# To run the script, you must have installed Python 3.6 or later.`
`4`	`4`	`#`
`5`	`5`	`# In order to demonstrate adding a new default permission, this sample will create`
`6`	`6`	`# a new project and add a new capability to the new project, for the default "All users" group.`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`# This script demonstrates how to create a group using the Tableau`
`3`	`3`	`# Server Client.`
`4`	`4`	`#`
`5`		`-# To run the script, you must have installed Python 3.5 or later.`
	`5`	`+# To run the script, you must have installed Python 3.6 or later.`
`6`	`6`	`####`
`7`	`7`
`8`	`8`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`# parent_id.`
`5`	`5`	`#`
`6`	`6`	`#`
`7`		`-# To run the script, you must have installed Python 3.5 or later.`
	`7`	`+# To run the script, you must have installed Python 3.6 or later.`
`8`	`8`	`####`
`9`	`9`
`10`	`10`	`import argparse`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`# For more information, refer to the documentations on 'Query View Image'`
`6`	`6`	`# (https://onlinehelp.tableau.com/current/api/rest_api/en-us/help.htm)`
`7`	`7`	`#`
`8`		`-# To run the script, you must have installed Python 3.5 or later.`
	`8`	`+# To run the script, you must have installed Python 3.6 or later.`
`9`	`9`	`####`
`10`	`10`
`11`	`11`	`import argparse`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`# This script demonstrates how to export a view using the Tableau`
`3`	`3`	`# Server Client.`
`4`	`4`	`#`
`5`		`-# To run the script, you must have installed Python 3.5 or later.`
	`5`	`+# To run the script, you must have installed Python 3.6 or later.`
`6`	`6`	`####`
`7`	`7`
`8`	`8`	`import argparse`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`#`
`5`	`5`	# You will need to do `pip install PyPDF2` to use this sample.
`6`	`6`	`#`
`7`		`-# To run the script, you must have installed Python 3.5 or later.`
	`7`	`+# To run the script, you must have installed Python 3.6 or later.`
`8`	`8`	`####`
`9`	`9`
`10`	`10`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`# This script demonstrates how to filter and sort groups using the Tableau`
`3`	`3`	`# Server Client.`
`4`	`4`	`#`
`5`		`-# To run the script, you must have installed Python 3.5 or later.`
	`5`	`+# To run the script, you must have installed Python 3.6 or later.`
`6`	`6`	`####`
`7`	`7`
`8`	`8`