Scrub some strings in the test files #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping (I'm just OCD and want to clear my open PRs) /cc @RussTheAerialist |
|
I'm oof today because my dog is having a surgery. I'll take a look tomorrow
|
| @@ -42,7 +42,7 @@ def test_can_extract_federated_connections(self): | |||
| connections = parser.get_connections() | |||
| self.assertIsInstance(connections, list) | |||
| self.assertIsInstance(connections[0], Connection) | |||
| self.assertEqual(connections[0].dbname, 'testv1') | |||
| self.assertEqual(connections[0].dbname, 'TestV1') | |||
There was a problem hiding this comment.
The test asset had it lowercase too, my OCD said 'no' and I updated it to match the others
|
🚀 |
graysonarts
pushed a commit
that referenced
this pull request
Oct 7, 2016
* Scrub some strings in the test file so they don't include internal references * Updated some of the assets to be consistent in casing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the 'tsi.lan' suffix that's internal to Tableau and not really relevant for general usage