Merge pull request apple#3713 from etschannen/release-6.3

etschannen · web-flow · commit fcd59ae5da97 · 2020-08-31T15:21:20.000-07:00
fixed a compiler warning
diff --git a/flow/Arena.h b/flow/Arena.h
@@ -670,7 +670,7 @@ inline bool operator==(const StringRef& lhs, const StringRef& rhs) {
 	if (lhs.size() == 0 && rhs.size() == 0) {
 		return true;
 	}
-	return lhs.size() == rhs.size() && !memcmp(lhs.begin(), rhs.begin(), lhs.size());
+	return lhs.size() == rhs.size() && memcmp(lhs.begin(), rhs.begin(), lhs.size()) == 0;
 }
 inline bool operator<(const StringRef& lhs, const StringRef& rhs) {
 	if (std::min(lhs.size(), rhs.size()) > 0) {

Original file line number	Diff line number	Diff line change
`@@ -670,7 +670,7 @@ inline bool operator==(const StringRef& lhs, const StringRef& rhs) {`
`670`	`670`	`if (lhs.size() == 0 && rhs.size() == 0) {`
`671`	`671`	`return true;`
`672`	`672`	`}`
`673`		`- return lhs.size() == rhs.size() && !memcmp(lhs.begin(), rhs.begin(), lhs.size());`
	`673`	`+ return lhs.size() == rhs.size() && memcmp(lhs.begin(), rhs.begin(), lhs.size()) == 0;`
`674`	`674`	`}`
`675`	`675`	`inline bool operator<(const StringRef& lhs, const StringRef& rhs) {`
`676`	`676`	`if (std::min(lhs.size(), rhs.size()) > 0) {`