Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename index.ts to _app.ts #606

Merged
merged 3 commits into from
Oct 13, 2022
Merged

feat: rename index.ts to _app.ts #606

merged 3 commits into from
Oct 13, 2022
+12 −9

Conversation

c-ehrlich
Copy link
Member

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

The tRPC docs now use the pattern of naming the index router _app.ts [1] [2]. This PR updates our template and docs to be the same.

💯

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: e9d1073

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 3:50PM (UTC)

@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation labels Oct 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 84
🟢 Accessibility 100
🟢 Best practices 93
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-fork-c-ehrlich-rename-index-router-t3-oss.vercel.app/

juliusmarminge
juliusmarminge approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like index more cause you can use the ~/server/router import but I guess we go with the docs

@c-ehrlich
Copy link
Member Author

I don't love the _app.ts naming either tbh. But imo if they stick with it, we should use it too.

Could ask the tRPC team what the motivation for this naming is?

@c-ehrlich
Copy link
Member Author

Alex made a good point: it comes first in alphabetical order.

@juliusmarminge juliusmarminge enabled auto-merge (squash) October 13, 2022 15:50
@juliusmarminge
Copy link
Member

Ship it

@juliusmarminge juliusmarminge merged commit 7f73518 into t3-oss:next Oct 13, 2022
@github-actions github-actions bot mentioned this pull request Oct 13, 2022
Merged
@c-ehrlich c-ehrlich deleted the rename-index-router branch October 13, 2022 16:03
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@c-ehrlich
feat: rename index.ts to _app.ts (t3-oss#606)
8626ab6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusmarminge juliusmarminge juliusmarminge approved these changes

@nexxeln nexxeln Awaiting requested review from nexxeln

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

Assignees
No one assigned
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App 📚 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-ehrlich @juliusmarminge