chore: bump typescript-eslint to v8 #1936

JoshuaKGoldberg · 2024-07-06T16:12:56Z

👋 Hi! Coming over from typescript-eslint/typescript-eslint#9141: we're working on typescript-eslint v8 and would like to try the beta out on repos like this one.

I'm sending this draft PR as a reference to see what issues we might give you in upgrading and to try to be helpful. If this is annoying noise to you, please forgive me, I'll withdraw the PR. But I hope this is useful on your end - and please let me know if you have any feedback! ❤️

I've put inline comments on any changes. There shouldn't be anything user-facing (this isn't a feat: or fix: PR).

For reference, #1476 was a similar PR that bumped typescript-eslint to v6. Hello again! 😄

changeset-bot · 2024-07-06T16:13:00Z

🦋 Changeset detected

Latest commit: f12dbe4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
create-t3-app	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-07-06T16:13:01Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
create-t3-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 19, 2024 8:26am

vercel · 2024-07-06T16:13:02Z

@JoshuaKGoldberg is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

JoshuaKGoldberg · 2024-07-06T16:19:36Z

.eslintrc.cjs

-      "./upgrade/tsconfig.json",
-      "./www/tsconfig.json",
-    ],
+    projectService: true,


https://typescript-eslint.io/blog/announcing-typescript-eslint-v8-beta#project-service: this is our snazzy new way of enabling typed linting. It should be faster and require less configuration.

I couldn't tell from quickly reading the code: what is the tsconfig.eslint.json doing differently? Is it still necessary?

Btw, I ran hyperfine measurements, and they showed promising performance improvements on my M1 Max Mac Studio:

~10% faster bumping to typescript-eslint from v7 to v8

~20% faster again switching from project to projectService

# baseline: typescript-eslint@v7 with project Benchmark 1: npx turbo lint --no-cache Time (mean ± σ): 7.464 s ± 0.094 s [User: 32.604 s, System: 2.431 s] Range (min … max): 7.346 s … 7.665 s 10 runs

# typescript-eslint@v8 with project Benchmark 1: npx turbo lint --no-cache Time (mean ± σ): 6.662 s ± 0.235 s [User: 29.944 s, System: 2.253 s] Range (min … max): 6.501 s … 7.254 s 10 runs

# typescript-eslint@v8 with projectService Benchmark 1: npx turbo lint --no-cache Time (mean ± σ): 5.344 s ± 0.126 s [User: 25.637 s, System: 1.683 s] Range (min … max): 5.204 s … 5.554 s 10 runs

...for an overall performance improvement of roughly 28%.

I couldn't tell from quickly reading the code: what is the tsconfig.eslint.json doing differently? Is it still necessary?

I can't remember why it's there but from guessing it sounds like projectService does it for us :)

JoshuaKGoldberg · 2024-07-06T16:20:22Z

cli/src/helpers/git.ts

@@ -12,7 +12,7 @@ const isGitInstalled = (dir: string): boolean => {
  try {
    execSync("git --version", { cwd: dir });
    return true;
-  } catch (_e) {
+  } catch {


As of typescript-eslint/typescript-eslint#8971, these are now flagged by default by @typescript-eslint/no-unused-vars. They were unused before.

JoshuaKGoldberg · 2024-07-06T16:21:37Z

cli/src/helpers/logNextSteps.ts

-  projectName !== "." && logger.info(`  cd ${projectName}`);
+  if (projectName !== ".") {
+    logger.info(`  cd ${projectName}`);
+  }


@typescript-eslint/no-unused-expressions was promoted to the recommended config in v8.

JoshuaKGoldberg · 2024-07-06T16:22:41Z

cli/src/utils/renderVersionWarning.ts

            reject();
          }
        }
      )
      .on("error", () => {
        // logger.error("Unable to check for latest version.");
+        // eslint-disable-next-line @typescript-eslint/prefer-promise-reject-errors
        reject();


This is the first time I can remember seeing reject() called with no argument. Interesting!

@typescript-eslint/prefer-promise-reject-errors was promoted to the strict-type-checked config in v8.

probably should reject with a descriptive error xd

JoshuaKGoldberg · 2024-07-06T16:23:31Z

upgrade/src/app/api/og/route.tsx

-      const u = font.match(/src: url\((.+)\) format\('(opentype|truetype)'\)/);
-      const w = font.match(/font-weight: (\d+)/);
+      const u = /src: url\((.+)\) format\('(opentype|truetype)'\)/.exec(font);
+      const w = /font-weight: (\d+)/.exec(font);


@typescript-eslint/prefer-regexp-exec was promoted to the stylistic-type-checked config in v8.

JoshuaKGoldberg · 2024-07-06T16:24:30Z

www/src/languages.ts

@@ -32,7 +32,7 @@ export function getIsRtlFromUrl(pathname: string) {
 }

 export function getIsRtlFromLangCode(language: KnownLanguageCode) {
-  if (rtlLanguages.indexOf(language) !== -1) {
+  if (rtlLanguages.includes(language)) {


@typescript-eslint/prefer-includes was promoted to the stylistic-type-checked config in v8.

cli/template/base/package.json

Co-authored-by: Sebastian Barrenechea <sebastian@barrenechea.cl>

JoshuaKGoldberg · 2024-08-13T16:10:03Z

I don't know what's going on with CI, but 🤷 putting in review.

juliusmarminge · 2024-08-19T08:08:40Z

I don't know what's going on with CI, but 🤷 putting in review.

This looks like a version mismatch in next-auth's types...

juliusmarminge · 2024-08-19T08:21:28Z

package.json

+  "resolutions": {
+    "@typescript-eslint/eslint-plugin": "8.1.0",
+    "@typescript-eslint/parser": "8.1.0"


can this be removed nnow?

looks like something resolved to v7 when removing this so leaving it in

JoshuaKGoldberg · 2024-08-19T13:13:07Z

Awesome, thanks @juliusmarminge! ❤️

chore: bump typescript-eslint to v8

a742add

vercel bot deployed to Preview – create-t3-app July 6, 2024 16:13 View deployment

JoshuaKGoldberg commented Jul 6, 2024

View reviewed changes

JoshuaKGoldberg mentioned this pull request Jul 6, 2024

Try out v8 beta on various influential community repos typescript-eslint/typescript-eslint#9141

Closed

juliusmarminge reviewed Jul 22, 2024

View reviewed changes

cli/template/base/package.json Outdated Show resolved Hide resolved

JoshuaKGoldberg mentioned this pull request Jul 24, 2024

docs: blog post on parserOptions.projectService typescript-eslint/typescript-eslint#8031

Draft

8 tasks

JoshuaKGoldberg mentioned this pull request Jul 31, 2024

⚡ Performance: parserOptions.projectService sometimes no longer outperforms parserOptions.project typescript-eslint/typescript-eslint#9571

Open

Update cli/template/base/package.json

2b0d1e4

Co-authored-by: Sebastian Barrenechea <sebastian@barrenechea.cl>

vercel bot deployed to Preview – create-t3-app August 13, 2024 15:09 View deployment

bump to stable, yay

70c1a97

vercel bot deployed to Preview – create-t3-app August 13, 2024 15:12 View deployment

Merge branch 'main'

fbe1983

vercel bot deployed to Preview – create-t3-app August 13, 2024 15:25 View deployment

JoshuaKGoldberg marked this pull request as ready for review August 13, 2024 16:10

JoshuaKGoldberg requested review from nexxeln, t3dotgg and c-ehrlich as code owners August 13, 2024 16:10

sync versions of drizzle-kit

8078722

vercel bot deployed to Preview – create-t3-app August 19, 2024 08:20 View deployment

juliusmarminge approved these changes Aug 19, 2024

View reviewed changes

changeset

f12dbe4

vercel bot deployed to Preview – create-t3-app August 19, 2024 08:26 View deployment

juliusmarminge enabled auto-merge August 19, 2024 08:27

juliusmarminge added this pull request to the merge queue Aug 19, 2024

juliusmarminge removed this pull request from the merge queue due to a manual request Aug 19, 2024

juliusmarminge merged commit 2d1878e into t3-oss:main Aug 19, 2024
266 of 267 checks passed

github-actions bot mentioned this pull request Aug 19, 2024

chore(release): version packages #1967

Merged

JoshuaKGoldberg deleted the typescript-eslint-8 branch August 19, 2024 11:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump typescript-eslint to v8 #1936

chore: bump typescript-eslint to v8 #1936

JoshuaKGoldberg commented Jul 6, 2024

changeset-bot bot commented Jul 6, 2024 •

edited

Loading

vercel bot commented Jul 6, 2024 •

edited

Loading

vercel bot commented Jul 6, 2024

JoshuaKGoldberg Jul 6, 2024 •

edited

Loading

juliusmarminge Jul 22, 2024

JoshuaKGoldberg Jul 6, 2024

JoshuaKGoldberg Jul 6, 2024 •

edited

Loading

JoshuaKGoldberg Jul 6, 2024

juliusmarminge Jul 22, 2024

JoshuaKGoldberg Jul 6, 2024

JoshuaKGoldberg Jul 6, 2024

JoshuaKGoldberg commented Aug 13, 2024

juliusmarminge commented Aug 19, 2024 •

edited

Loading

juliusmarminge Aug 19, 2024

juliusmarminge Aug 19, 2024

JoshuaKGoldberg commented Aug 19, 2024

chore: bump typescript-eslint to v8 #1936

chore: bump typescript-eslint to v8 #1936

Conversation

JoshuaKGoldberg commented Jul 6, 2024

changeset-bot bot commented Jul 6, 2024 • edited Loading

🦋 Changeset detected

vercel bot commented Jul 6, 2024 • edited Loading

vercel bot commented Jul 6, 2024

JoshuaKGoldberg Jul 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoshuaKGoldberg Jul 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoshuaKGoldberg commented Aug 13, 2024

juliusmarminge commented Aug 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoshuaKGoldberg commented Aug 19, 2024

changeset-bot bot commented Jul 6, 2024 •

edited

Loading

vercel bot commented Jul 6, 2024 •

edited

Loading

JoshuaKGoldberg Jul 6, 2024 •

edited

Loading

JoshuaKGoldberg Jul 6, 2024 •

edited

Loading

juliusmarminge commented Aug 19, 2024 •

edited

Loading