Fix gin-gonic#3500 Add escape logic for header

t0rchwo0d · Feb 17, 2023 · c22614f · c22614f
1 parent 81ac7d5
commit c22614f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/gin.go b/gin.go
@@ -670,8 +670,11 @@ func redirectTrailingSlash(c *Context) {
 	p := req.URL.Path
 	if prefix := path.Clean(c.Request.Header.Get("X-Forwarded-Prefix")); prefix != "." {
 		prefix = url.QueryEscape(prefix)
+		prefix = strings.ReplaceAll(prefix, ".", "")
 		prefix = strings.ReplaceAll(prefix, "%2F", "/")
 
+		fmt.Println(prefix)
+
 		p = prefix + "/" + req.URL.Path
 	}
 	req.URL.Path = p + "/"

diff --git a/routes_test.go b/routes_test.go
@@ -186,11 +186,11 @@ func TestRouteRedirectTrailingSlash(t *testing.T) {
 	assert.Equal(t, 200, w.Code)
 
 	w = PerformRequest(router, http.MethodGet, "/path/", header{Key: "X-Forwarded-Prefix", Value: "../../bug#?"})
-	assert.Equal(t, "../../../bug%2523%253F/path", w.Header().Get("Location"))
+	assert.Equal(t, "//bug%2523%253F//path", w.Header().Get("Location"))
 	assert.Equal(t, 301, w.Code)
 
 	w = PerformRequest(router, http.MethodGet, "/path/", header{Key: "X-Forwarded-Prefix", Value: "https://gin-gonic.com/#"})
-	assert.Equal(t, "https%3A/gin-gonic.com/%23/https%253A/gin-gonic.com/%2523/path", w.Header().Get("Location"))
+	assert.Equal(t, "https%3A/gin-goniccom/%23/https%253A/gin-goniccom/%2523/path", w.Header().Get("Location"))
 	assert.Equal(t, 301, w.Code)
 
 	w = PerformRequest(router, http.MethodGet, "/path/", header{Key: "X-Forwarded-Prefix", Value: "#bug"})