Improve Bash process detection #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montag451
force-pushed
the
bash-process-detection
branch
from
c2196fc to
f92736d
Compare
The current way of checking if a process is a Bash process is not correct particularly with remote Bash processes. For example if the user shell on the local machine is zsh then `shell-file-name' will be equal to zsh and `bash-completion--current-shell' will return nil for a remote Bash process (assuming `explicit-shell-file-name' is nil and the ESHELL environment variable is not set). The new way of checking if a process is a Bash process is more robust as it is not based on the checking of the `explicit-shell-file-name' variable, the ESHELL environment variable, the `shell-file-name' variable or the local command used to launch the Bash process.
montag451
force-pushed
the
bash-process-detection
branch
from
f92736d to
08c4bca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way of checking if a process is a Bash process is not correct particularly with remote Bash processes. For example if the user shell on the local machine is zsh then
shell-file-namewill be equal to zsh andbash-completion--current-shellwill return nil for a remote Bash process (assumingexplicit-shell-file-nameis nil and the ESHELL environment variable is not set). The new way of checking if a process is a Bash process is more robust as it is not based on the checking of theexplicit-shell-file-namevariable, the ESHELL environment variable, theshell-file-namevariable or the local command used to launch the Bash process.