Skip to content
This repository has been archived by the owner on Oct 9, 2020. It is now read-only.

Inline source maps option #74

Closed
crisptrutski opened this issue Feb 13, 2015 · 6 comments · Fixed by #82
Closed

Inline source maps option #74

crisptrutski opened this issue Feb 13, 2015 · 6 comments · Fixed by #82
Assignees

Comments

@crisptrutski
Copy link
Contributor

Write out source map as data URL rather than separate file.

@hgl just creating this issue, as we basically have the functionality, but curious to know your use case.

Would you assume / require that the inlined source map always contains sourcesContent?

@crisptrutski crisptrutski self-assigned this Feb 18, 2015
@crisptrutski
Copy link
Contributor Author

@guybedford opts = {inlineSourceMaps: true} or {sourceMaps: 'inline'}?

@guybedford
Copy link
Member

I guess sourceMaps: 'inline' is the trend, and is easier to write.

@crisptrutski
Copy link
Contributor Author

Well Dart doesn't support union types yet AFAIK, so it just forces annotations to any..

I guess we're helping fight the righteous battle for union types then, that's good.

@hgl
Copy link

hgl commented Feb 19, 2015

Thank you for creating this issue. (Somehow I missed this issue, so sorry to chime in this late.)

I would expect inlined source map to always contain sourcesContent, since inlining already implies being self-contained. The use cause is the one I mentioned in #68: not having to make source files available to the web server.

@crisptrutski
Copy link
Contributor Author

@hgl added some changes so that the relevant option will come into effect once #68 is closed

@hgl
Copy link

hgl commented Feb 20, 2015

Great, thank you for making our lives easier, really appreciate it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants