Skip to content

Force a new change set when testing functions on head #5230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Force a new change set when testing functions on head #5230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/sdf-server/src/service/v2/func/test_execute.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,16 @@ use axum::{
Json,
};
use dal::{
func::authoring::FuncAuthoringClient, ChangeSetId, ComponentId, Func, FuncId, WorkspacePk,
func::authoring::FuncAuthoringClient, ChangeSet, ChangeSetId, ComponentId, Func, FuncId,
WorkspacePk,
};
use serde::{Deserialize, Serialize};
use si_events::{audit_log::AuditLogKind, FuncRunId};

use super::FuncAPIResult;
use crate::{
extract::{AccessBuilder, HandlerContext, PosthogClient},
service::force_change_set_response::ForceChangeSetResponse,
track,
};

Expand All @@ -36,10 +38,11 @@ pub async fn test_execute(
Host(host_name): Host,
Path((_workspace_pk, change_set_id, func_id)): Path<(WorkspacePk, ChangeSetId, FuncId)>,
Json(request): Json<TestExecuteFuncRequest>,
) -> FuncAPIResult<Json<TestExecuteFuncResponse>> {
let ctx = builder
) -> FuncAPIResult<ForceChangeSetResponse<TestExecuteFuncResponse>> {
let mut ctx = builder
.build(access_builder.build(change_set_id.into()))
.await?;
let force_change_set_id = ChangeSet::force_new(&mut ctx).await?;

let func = Func::get_by_id_or_error(&ctx, func_id).await?;
let func_run_id = FuncAuthoringClient::test_execute_func(
Expand Down Expand Up @@ -75,5 +78,8 @@ pub async fn test_execute(
.await?;
ctx.commit().await?;

Ok(Json(TestExecuteFuncResponse { func_run_id }))
Ok(ForceChangeSetResponse::new(
force_change_set_id,
TestExecuteFuncResponse { func_run_id },
))
}
Loading