SSPROD-48664 - update(org): include/exclude optional fields #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinadhruve10
approved these changes
Jan 28, 2025
Contributor
ravinadhruve10
left a comment
ravinadhruve10
left a comment
There was a problem hiding this comment.
I believe we can't release this change till the TF provider release tag is updated in versions.tf.
Contributor
ravinadhruve10
left a comment
ravinadhruve10
left a comment
There was a problem hiding this comment.
Overall lgtm, one comment on the test examples.
jose-pablo-camacho
deleted the
update/organization/include-exclude-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: https://sysdig.atlassian.net/browse/SSPROD-48664
Will keep this for now since foundational (onboarding + CSPM) only creates a role in the management account - we will test everything related to org scraping works with new include/exclude fields, for provisioning logic for different features we will need to circle back.