Better retry, waiting and timeout for 'analyzed' step and getting scan report #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation would wait fixed 2x10s after the image was uploaded to Secure because of number of retries code being always executed, then tried to get scan report.
That would be too much if the scan was already cached in Secure and immediately available, or too little if scan result was delayed (when the script says 'analyzed', it means it has received the image, not that the scan has finished).
Now if the scan report is available immediately, there is no delay getting it, and if it's not, a retry for the timeout period is done in incremental steps of 5s, 10s, 15s... to avoid overloading the backend when things get slow.