Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named tuple serialisation should include parameter names #106

Closed
iamogbz opened this issue Jan 13, 2020 · 0 comments · Fixed by #108
Closed

Named tuple serialisation should include parameter names #106

iamogbz opened this issue Jan 13, 2020 · 0 comments · Fixed by #108
Labels
bug Something isn't working feature request New feature or request serializer Syrupy serializer question
Milestone
v1.0.0

Comments

@iamogbz
Copy link
Collaborator

iamogbz commented Jan 13, 2020

Describe the bug

Named tuples when serialised loose argument information

To Reproduce
Steps to reproduce the behavior:

  1. See current example or named tuple serialisation in the test amber snapshots

Expected behavior
Parameter names should be sorted and preserved like a dictionary or class

Screenshots
N/A

Desktop (please complete the following information):

  • v0.2.0

Additional context
Add any other context about the problem here.
@iamogbz iamogbz added bug Something isn't working feature request New feature or request serializer Syrupy serializer question labels Jan 13, 2020
@iamogbz iamogbz added this to the v1.0.0 milestone Jan 13, 2020
@iamogbz iamogbz mentioned this issue Jan 13, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working feature request New feature or request serializer Syrupy serializer question
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

feat: update serialization to support named tuple fields syrupy-project/syrupy
1 participant
@iamogbz