Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite specification #18

Closed
wants to merge 1 commit into from
Closed

Rewrite specification #18

wants to merge 1 commit into from

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Aug 24, 2018

Closes GH-17.

@wooorm
Copy link
Member Author

wooorm commented Aug 24, 2018

Looking for reviewers! 👓

@wooorm
Copy link
Member Author

wooorm commented Aug 26, 2018

/CC @ChristianMurphy @ikatyang perchance?

Feel free to ignore, I’ll merge in a few days.

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

readme.md Outdated

* **concrete syntax trees**: structures that represent every detail (such
as white-space in white-space insensitive languages)
* **abstract syntax trees**: structures that only represent details relating
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one’s good, but I find the related CST article a bit lacking! I also really like this article: https://eli.thegreenplace.net/2009/02/16/abstract-vs-concrete-syntax-trees/.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link

@ikatyang ikatyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

* Reword `text` > `literal` (GH-17)
* Add introduction
* Reword definitions, terms
* Add more terms
* Add references
* Add more acknowledgements

Closes GH-17.

Reviewed-by: Christian Murphy <Christian.Murphy.42@gmail.com>
Reviewed-by: Ika <ikatyang@gmail.com>
@wooorm wooorm closed this in 8055bf4 Aug 27, 2018
@wooorm wooorm deleted the rewrite branch August 27, 2018 16:35
wooorm added a commit to syntax-tree/mdast that referenced this pull request Aug 28, 2018
* Update to the new style of unist
  <syntax-tree/unist@8055bf4>
* Rename `Text` > `Literal`, `TextNode` > `Text` (syntax-tree/unist#17)
* Reword definitions
* Add introduction, references, links to terms
* Add common mixins for shared fields
* Move enumerations to their own section
* Add description of content models (GH-21)
* Remove marking of YAML as non-standard

Related to syntax-tree/unist#18
Related to syntax-tree/unist#17
Closes GH-21.
wooorm added a commit to syntax-tree/mdast that referenced this pull request Aug 28, 2018
* Update to the new style of unist
  <syntax-tree/unist@8055bf4>
* Rename `Text` > `Literal`, `TextNode` > `Text` (syntax-tree/unist#17)
* Reword definitions
* Add introduction, references, links to terms
* Add common mixins for shared fields
* Move enumerations to their own section
* Add description of content models (GH-21)
* Remove marking of YAML as non-standard
* Make `list.ordered` optional (default: `false`)
* Make `list.loose` optional (default: `false`)
* Make `listItem.loose` optional (default: `false`)
* Make `table.align` optional
* Add references to CSS Text for alignTypes

Related to syntax-tree/unist#18
Related to syntax-tree/unist#17
Closes GH-21.
wooorm added a commit to syntax-tree/mdast that referenced this pull request Aug 31, 2018
* Update to the new style of unist
  <syntax-tree/unist@8055bf4>
* Rename `Text` > `Literal`, `TextNode` > `Text` (syntax-tree/unist#17)
* Reword definitions
* Add introduction, references, links to terms
* Add common mixins for shared fields
* Move enumerations to their own section
* Add description of content models (GH-21)
* Remove marking of YAML as non-standard
* Make `list.ordered` optional (default: `false`)
* Make `list.loose` optional (default: `false`)
* Remove `listItem.loose` (use `list.loose instead)
* Make `table.align` optional
* Add references to CSS Text for alignTypes

Related to syntax-tree/unist#18
Related to syntax-tree/unist#17
Closes GH-21.

Reviewed-by: Christian Murphy <Christian.Murphy.42@gmail.com>
Reviewed-by: Ika <ikatyang@gmail.com>
wooorm added a commit to syntax-tree/mdast that referenced this pull request Aug 31, 2018
* Update to the new style of unist
  <syntax-tree/unist@8055bf4>
* Rename `Text` > `Literal`, `TextNode` > `Text` (syntax-tree/unist#17)
* Reword definitions
* Add introduction, references, links to terms
* Add common mixins for shared fields
* Move enumerations to their own section
* Add description of content models (GH-21)
* Remove marking of YAML as non-standard
* Make `list.ordered` optional (default: `false`)
* Make `list.loose` optional (default: `false`)
* Remove `listItem.loose` (use `list.loose instead)
* Make `table.align` optional
* Add references to CSS Text for alignTypes

Related to syntax-tree/unist#18
Related to syntax-tree/unist#17
Closes GH-21.
Closes GH-24.

Reviewed-by: Christian Murphy <Christian.Murphy.42@gmail.com>
Reviewed-by: Ika <ikatyang@gmail.com>
@wooorm wooorm added ⛵️ status/released 📚 area/docs This affects documentation 🦋 type/enhancement This is great to have labels Aug 12, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 area/docs This affects documentation 💪 phase/solved Post is done 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

Rename abstract text interface to literal
3 participants