Skip to content

Commit 28b54f6

Browse files
committed
Add strict to tsconfig.json
1 parent e959553 commit 28b54f6

File tree

3 files changed

+31
-13
lines changed

3 files changed

+31
-13
lines changed

index.js

Lines changed: 23 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,31 @@ export function positionFromEstree(value) {
3535

3636
return {
3737
start: {
38-
line: loc.start && loc.start.line > -1 ? loc.start.line : null,
39-
column: loc.start && loc.start.column > -1 ? loc.start.column + 1 : null,
40-
offset: startOffset > -1 ? startOffset : null
38+
// @ts-expect-error: return no point / no position next major.
39+
line:
40+
loc.start && loc.start.line !== undefined && loc.start.line > -1
41+
? loc.start.line
42+
: undefined,
43+
// @ts-expect-error: return no point / no position next major.
44+
column:
45+
loc.start && loc.start.column !== undefined && loc.start.column > -1
46+
? loc.start.column + 1
47+
: undefined,
48+
offset:
49+
startOffset !== undefined && startOffset > -1 ? startOffset : undefined
4150
},
4251
end: {
43-
line: loc.end && loc.end.line > -1 ? loc.end.line : null,
44-
column: loc.end && loc.end.column > -1 ? loc.end.column + 1 : null,
45-
offset: endOffset > -1 ? endOffset : null
52+
// @ts-expect-error: return no point / no position next major.
53+
line:
54+
loc.end && loc.end.line !== undefined && loc.end.line > -1
55+
? loc.end.line
56+
: undefined,
57+
// @ts-expect-error: return no point / no position next major.
58+
column:
59+
loc.end && loc.end.column !== undefined && loc.end.column > -1
60+
? loc.end.column + 1
61+
: undefined,
62+
offset: endOffset !== undefined && endOffset > -1 ? endOffset : undefined
4663
}
4764
}
4865
}

test.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,17 @@ test('unist-util-position-from-estree', (t) => {
66
t.deepEqual(
77
positionFromEstree(),
88
{
9-
start: {line: null, column: null, offset: null},
10-
end: {line: null, column: null, offset: null}
9+
start: {line: undefined, column: undefined, offset: undefined},
10+
end: {line: undefined, column: undefined, offset: undefined}
1111
},
1212
'should support a missing node'
1313
)
1414

1515
t.deepEqual(
1616
positionFromEstree(parse('x', {ecmaVersion: 2020})),
1717
{
18-
start: {line: null, column: null, offset: 0},
19-
end: {line: null, column: null, offset: 1}
18+
start: {line: undefined, column: undefined, offset: 0},
19+
end: {line: undefined, column: undefined, offset: 1}
2020
},
2121
'should support node w/o `loc`s'
2222
)
@@ -33,8 +33,8 @@ test('unist-util-position-from-estree', (t) => {
3333
t.deepEqual(
3434
positionFromEstree(parse('x', {ecmaVersion: 2020, ranges: true})),
3535
{
36-
start: {line: null, column: null, offset: 0},
37-
end: {line: null, column: null, offset: 1}
36+
start: {line: undefined, column: undefined, offset: 0},
37+
end: {line: undefined, column: undefined, offset: 1}
3838
},
3939
'should support node w/ `range`s'
4040
)

tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"declaration": true,
1111
"emitDeclarationOnly": true,
1212
"allowSyntheticDefaultImports": true,
13-
"skipLibCheck": true
13+
"skipLibCheck": true,
14+
"strict": true
1415
}
1516
}

0 commit comments

Comments
 (0)