Skip to content

Removes URL import #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Removes URL import #70

wants to merge 1 commit into from

Conversation

arcanis
Copy link

@arcanis arcanis commented Jan 6, 2022 •
edited by wooorm
Loading

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Node 10+ provide URL as a global. Importing it from url (or node:url) is unnecessary and causes problems when importing hast-util-to-mdast inside a browser context (because you then have to polyfill url).

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Jan 6, 2022
@github-actions

This comment has been minimized.

Sign in to view
@wooorm
Copy link
Member

wooorm commented Jan 7, 2022

Unfortunately TypeScript doesn’t understand it.

Your bundler should understand it though, what are you using?

@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jan 7, 2022
@wooorm wooorm closed this Jan 9, 2022
@wooorm wooorm added 🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on labels Jan 9, 2022
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jan 9, 2022
@lxcid
Copy link
Contributor

lxcid commented Feb 5, 2022

This is a problem for us though, this import make it an issue for us to use it in browser, which have this by default.

@lxcid lxcid mentioned this pull request Feb 5, 2022
Merged
5 tasks
wooorm pushed a commit that referenced this pull request Feb 6, 2022
@lxcid
Remove use of URL from node:url
135288e 
Also:

* add locks of TS for now
* update test fixture for external formatting improvements

Related-to GH-70.
Closes GH-71.

Reviewed-by: Titus Wormer <tituswormer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arcanis @wooorm @lxcid