Cannot compile unknown node `login`

[albinekb]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions

hast-util-to-html@9.0.3

Link to runnable example

No response

Steps to reproduce

const processor = unified()
    .use(rehypeParse, { fragment: true, emitParseErrors: true })
    .use(rehypeFormat, { blanks: [], indent: 0 })
    .use(rehypeStringify, { allowParseErrors: true})
    
const vfile = await processor.process('<button type="login">Click me</button>')

const text = vfile.toString()

Cannot compile unknown node `login`
    at unknown (node_modules/.pnpm/hast-util-to-html@9.0.3/node_modules/hast-util-to-html/lib/handle/index.js:46:9)
    at one (node_modules/.pnpm/zwitch@2.0.4/node_modules/zwitch/index.js:108:17)
    at Object.one (node_modules/.pnpm/hast-util-to-html@9.0.3/node_modules/hast-util-to-html/lib/index.js:234:10)
    at Object.all (node_modules/.pnpm/hast-util-to-html@9.0.3/node_modules/hast-util-to-html/lib/index.js:253:27)
    at element (node_modules/.pnpm/hast-util-to-html@9.0.3/node_modules/hast-util-to-html/lib/handle/element.js:78:25)
    at one (node_modules/.pnpm/zwitch@2.0.4/node_modules/zwitch/index.js:108:17)
    at Object.one (node_modules/.pnpm/hast-util-to-html@9.0.3/node_modules/hast-util-to-html/lib/index.js:234:10)
    at Object.all (node_modules/.pnpm/hast-util-to-html@9.0.3/node_modules/hast-util-to-html/lib/index.js:253:27)
    at element (node_modules/.pnpm/hast-util-to-html@9.0.3/node_modules/hast-util-to-html/lib/handle/element.js:78:25)
    at one (node_modules/.pnpm/zwitch@2.0.4/node_modules/zwitch/index.js:108:17)

Expected behavior

No error is thrown or I can allow undefined values on attributes when stringifying

Actual behavior

Crashes when type is bogus value

Affected runtime and version

node@20.17.0

Affected package manager and version

pnpm@9.4.0

Affected OS and version

No response

Build and bundle tools

No response

[wooorm]

Hi!

• login is not a valid value for type on button — do not write incorrect HTML.
• when you post code, remove everything that is not needed. Remove all the fields of all the options you do not needed, remove all the plugins you do not need, please, thanks.
• can you please post version numbers of all the things? and make sure they are up to date?

[albinekb]

Thanks for getting back so quickly!

After digging more I see that this package is not the source of the issue, opened an issue over there instead: syntax-tree/hast-util-from-html#8
Repro here: https://github.com/albinekb/hast-unknown-node-repro/blob/main/index.ts

login is not a valid value for type on button — do not write incorrect HTML.

Sadly I'm not the author of the HTML thats being parsed, not in my control. I expect the HTML parsing to not break if there's non-standard properties.

when you post code, remove everything that is not needed. Remove all the fields of all the options you do not needed, remove all the plugins you do not need, please, thanks.

I apologize for the rushed issue. Now added reproduction and found a fix.
Opened a PR

can you please post version numbers of all the things? and make sure they are up to date?

The issue in the end has already been fixed in hastscript@9.0.0

Adding this to my package.json fixes the issue 🎉

"pnpm": {
  "overrides": {
    "hast-util-from-parse5@8.0.1>hastscript": "9.0.0"
  }
}

[github-actions]

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

[wooorm]

Released in hast-util-from-parse5@8.0.2, thank you for working on this!