Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transfer): refresh LDK after CJIT #2315

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix(transfer): refresh LDK after CJIT #2315

merged 1 commit into from
Oct 21, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Oct 21, 2024

Description

Need to refresh LDK after a CJIT channel has been opened for the channel to become usable.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

@pwltr pwltr requested a review from limpbrains October 21, 2024 09:36
limpbrains
limpbrains approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@limpbrains limpbrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a type of thing that should be fixed in RN-LDK
cc @Jasonvdb

@pwltr pwltr merged commit 7f7164a into master Oct 21, 2024
7 checks passed
@pwltr pwltr deleted the fix/cjit-balance branch October 21, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limpbrains limpbrains limpbrains approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwltr @limpbrains