Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android startup time is slow #2014

Open
ovitrif opened this issue Jun 25, 2024 · 6 comments · Fixed by #2231
Open

Android startup time is slow #2014

ovitrif opened this issue Jun 25, 2024 · 6 comments · Fixed by #2231
Assignees
Labels
enhancement New feature or request

Comments

@ovitrif
Copy link
Contributor

ovitrif commented Jun 25, 2024

This task is to coordinate the work to improve the startup time on Android, ie. opening the app when it's not in background.

In my case, with Pixel 7 Pro it's a random time that always exceeds 5 sec, and there are times when it hangs for as long as ± 16 sec.

Refs

See ….slack.com/archives/C01H106JRQB/p1718628911888799

@ovitrif ovitrif self-assigned this Jun 25, 2024
@ovitrif ovitrif added the enhancement New feature or request label Jun 25, 2024
@ovitrif
Copy link
Contributor Author

ovitrif commented Jun 25, 2024

Tested whether if the fork of react-native-keychain might have slowed down the startup time and concluded it didn't in any significant way, with only 1-2 seconds diff in startup speed comparing the original library on the latest version with our fork.

@ovitrif
Copy link
Contributor Author

ovitrif commented Jun 25, 2024

I watched the adb logs in Android Studio when building & running the debug app from it, there is literally a lot of time (4-10s) between the first log entry mentioning "loading native bindings" and the last one, all different libs with their different bindings. This led me to investigate common knowledge on the speed of loading native bindings in the JVM, an investigation which concludes that most of the performance hit might be rooted in this:

@ovitrif ovitrif changed the title Startup time on Android too slow Startup time on Android quite slow Jun 25, 2024
@ovitrif ovitrif changed the title Startup time on Android quite slow Android startup time is slow Jul 2, 2024
@ovitrif ovitrif assigned pwltr and unassigned ovitrif Jul 11, 2024
@ovitrif
Copy link
Contributor Author

ovitrif commented Jul 11, 2024

@pwltr I assigned this to you based on my understanding from yesterday's sync call. If you're not working on it feel free to reassign to me 👍🏻

@JeanlChristophe
Copy link

I think now we can close this ticket. can be reopen later if needed.

@pwltr
Copy link
Collaborator

pwltr commented Sep 3, 2024

We can probably have this in the backlog but it definitely needs to be improved.

@pwltr
Copy link
Collaborator

pwltr commented Oct 21, 2024

Waiting for upstream fix in react-native-keychain.

@pwltr pwltr reopened this Oct 21, 2024
@pwltr pwltr mentioned this issue Dec 6, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants