Improve readme #52
Merged
Improve readme #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moorepants
reviewed
Apr 21, 2019
|
|
||
| or in conda environment, use | ||
|
|
||
| ``conda install -c conda-forge virtualenv`` to install the dependency. |
Member
There was a problem hiding this comment.
I can't imagine that this is a good idea.
i would be better to recommend using conda environments in asf.conf.json.
Member
There was a problem hiding this comment.
probably, I can't remember why we opted to keep virtualenv as the default.
Member
There was a problem hiding this comment.
I just swap out the conf file on my benchmark machine and use conda. Here is an issue: #4
Member
bjodah
approved these changes
Apr 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
sympy/sympy#16652 (comment)
We don't need to make a full tutorial here, but I think we need some strong guide for the sympy main developers, about how to run the benchmarks locally to compare across forks or such.
I have added some basic tutorials