Skip to content

Conversation

@amartinhernan
Copy link
Contributor

@amartinhernan amartinhernan commented Mar 3, 2020

References to other Issues or PRs

Fixes #18753

Brief description of what is fixed or changed

Switching the two lines specified in this comment #18753 (comment).

Other comments

Release Notes

  • physics.continuum_mechanics
    • draw method follows sign convention of positive moment/counterclockwise application

@sympy-bot
Copy link

sympy-bot commented Mar 3, 2020

Hi, I am the SymPy bot (v157). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • physics.continuum_mechanics
    • draw method follows sign convention of positive moment/counterclockwise application (#18766 by @amartinhernan)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
Fixes https://github.com/sympy/sympy/issues/18753
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed
Switching the two lines specified in this comment https://github.com/sympy/sympy/issues/18753#issue-573597895.


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* physics.continuum_mechanics
   * `draw` method follows sign convention of positive moment/counterclockwise application
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #18766 into master will decrease coverage by 0.012%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##            master   #18766       +/-   ##
============================================
- Coverage   75.663%   75.65%   -0.013%     
============================================
  Files          647      647               
  Lines       168438   168438               
  Branches     39686    39686               
============================================
- Hits        127446   127425       -21     
- Misses       35434    35458       +24     
+ Partials      5558     5555        -3

@smichr
Copy link
Member

smichr commented Mar 3, 2020

Thanks for the cleanup of commits and the fix to the issue. Based on @moorepants comment about this being the "likely right fix" I will commit this as is.

@smichr smichr merged commit 88c7075 into sympy:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistency in the sign criterion new draw method.

3 participants