Return sympy integers instead of python integers

[namannimmo10]

References to other Issues or PRs

Fixes #18338

Brief description of what is fixed or changed

Other comments

Release Notes

• functions
  • Sympified output numbers for factorial and binomial used with Mod.

[sympy-bot]

✅

Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

• functions
  • Sympified output numbers for factorial and binomial used with Mod. (#18339 by @namannimmo10)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->
Fixes #18338


#### Brief description of what is fixed or changed


#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
*   functions
      *   Sympified output numbers for `factorial` and `binomial` used with `Mod`.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

[sylee957]

Can you add some test cases for the cases I have mentioned in the OP?
It should be like assert Mod(factorial(4, evaluate=False), 3) is S.Zero

[czgdp1807]

IMHO, we can add release notes entry for this PR.

[codecov]

Codecov Report

Merging #18339 into master will decrease coverage by 0.009%.
The diff coverage is 71.428%.

@@             Coverage Diff              @@
##            master    #18339      +/-   ##
============================================
- Coverage   75.014%   75.005%   -0.01%     
============================================
  Files          649       649              
  Lines       167443    167342     -101     
  Branches     39414     39416       +2     
============================================
- Hits        125607    125515      -92     
+ Misses       36299     36289      -10     
- Partials      5537      5538       +1

[namannimmo10]

ping @sylee957

[namannimmo10]

That didn't increase the coverage.. is there any other way around?

[oscarbenjamin]

It doesn't look like codecov has updated yet. The codecov comment is still before the most recent commit.

[namannimmo10]

It doesn't look like codecov has updated yet. The codecov comment is still before the most recent commit.

https://codecov.io/gh/sympy/sympy/pull/18339/commits

[namannimmo10]

It doesn't look like codecov has updated yet. The codecov comment is still before the most recent commit.

It hasn't updated yet, @oscarbenjamin

[namannimmo10]

@sylee957 Any updates on this one???