Skip to content

Fix Out of Index Error for is_upper() and is_upper_hessenberg() #12454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 31, 2017
Merged

Fix Out of Index Error for is_upper() and is_upper_hessenberg() #12454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
592b961
Remove the out of index error
Mar 29, 2017
5c56023
Add test
Mar 29, 2017
03ad467
Merge remote-tracking branch 'upstream/master' into Fixes#12452
Mar 30, 2017
0a50231
Add comma
Mar 30, 2017
8100815
Merge remote-tracking branch 'upstream/master' into Fixes#12452
Mar 30, 2017
d605b90
Update is_upper_hessenberg
Mar 30, 2017
75c1833
Add test for is_upper_hessenberg
Mar 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sympy/matrices/matrices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,7 @@ def _eval_is_zero(self):
def _eval_is_upper_hessenberg(self):
return all(self[i, j].is_zero
for i in range(2, self.rows)
for j in range(i - 1))
for j in range(min(self.cols, (i - 1))))

def _eval_values(self):
return [i for i in self if not i.is_zero]
Expand Down Expand Up @@ -1112,7 +1112,7 @@ def is_upper(self):
"""
return all(self[i, j].is_zero
for i in range(1, self.rows)
for j in range(i))
for j in range(min(i, self.cols)))

@property
def is_zero(self):
Expand Down
5 changes: 5 additions & 0 deletions sympy/matrices/tests/test_matrices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,6 +1225,8 @@ def test_is_upper():
assert a.is_upper is True
a = Matrix([[1], [2], [3]])
assert a.is_upper is False
a = zeros(4, 2)
assert a.is_upper is True


def test_is_lower():
Expand Down Expand Up @@ -1880,6 +1882,9 @@ def test_hessenberg():
A = Matrix([[3, 4, 1], [2, 4, 5], [3, 1, 2]])
assert not A.is_upper_hessenberg

A = zeros(5, 2)
assert A.is_upper_hessenberg


def test_cholesky():
raises(NonSquareMatrixError, lambda: Matrix((1, 2)).cholesky())
Expand Down