Skip to content

Commit c41e35b

Browse files
minor #61390 run tests with PHPUnit 12.3 (xabbuh)
This PR was merged into the 7.4 branch. Discussion ---------- run tests with PHPUnit 12.3 | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT The test updates reflect the following changes in PHPUnit 12.2 and 12.3: - a warning is emitted when a data provider provides data sets that have more values than the test method consuming the data set - the format in which data sets are displayed in test reports has changed affecting the modified test in the PhpUnitBridge (see sebastianbergmann/phpunit#6272) - errors triggered in the `tearDown()` method of skipped tests are no longer silence affecting the modified tests in the Form component where the `$defaultLocale` property is not initialised (see sebastianbergmann/phpunit#6281) Commits ------- cf7e41e1092 run tests with PHPUnit 12.3
2 parents d335e92 + 5257682 commit c41e35b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Tests/Constraints/LengthValidatorTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public static function getThreeCharactersWithWhitespaces()
117117
}
118118

119119
#[DataProvider('getFiveOrMoreCharacters')]
120-
public function testValidValuesMin(int|string $value)
120+
public function testValidValuesMin(int|string $value, int $valueLength)
121121
{
122122
$constraint = new Length(min: 5);
123123
$this->validator->validate($value, $constraint);
@@ -126,7 +126,7 @@ public function testValidValuesMin(int|string $value)
126126
}
127127

128128
#[DataProvider('getThreeOrLessCharacters')]
129-
public function testValidValuesMax(int|string $value)
129+
public function testValidValuesMax(int|string $value, int $valueLength)
130130
{
131131
$constraint = new Length(max: 3);
132132
$this->validator->validate($value, $constraint);

0 commit comments

Comments
 (0)