bug #60426 [Validator] let the SlugValidator accept AsciiSlugger results (xabbuh)

This PR was merged into the 7.3 branch.

Discussion
----------

[Validator] let the `SlugValidator` accept `AsciiSlugger` results

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | Fix symfony/symfony#58542 (comment)
| License       | MIT

Commits
-------

d51f563ed3c let the SlugValidator accept AsciiSlugger results

Author: nicolas-grekas

Constraints/Slug.php

@@ -25,7 +25,7 @@ class Slug extends Constraint
     public const NOT_SLUG_ERROR = '14e6df1e-c8ab-4395-b6ce-04b132a3765e';
 
     public string $message = 'This value is not a valid slug.';
-    public string $regex = '/^[a-z0-9]+(?:-[a-z0-9]+)*$/';
+    public string $regex = '/^[a-z0-9]+(?:-[a-z0-9]+)*$/i';
 
     #[HasNamedArguments]
     public function __construct(

Tests/Constraints/SlugValidatorTest.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Validator\Tests\Constraints;
 
+use Symfony\Component\String\Slugger\AsciiSlugger;
 use Symfony\Component\Validator\Constraints\Slug;
 use Symfony\Component\Validator\Constraints\SlugValidator;
 use Symfony\Component\Validator\Exception\UnexpectedValueException;
@@ -47,6 +48,7 @@ public function testExpectsStringCompatibleType()
      * @testWith ["test-slug"]
      *           ["slug-123-test"]
      *           ["slug"]
+     *           ["TestSlug"]
      */
     public function testValidSlugs($slug)
     {
@@ -56,8 +58,7 @@ public function testValidSlugs($slug)
     }
 
     /**
-     * @testWith ["NotASlug"]
-     *           ["Not a slug"]
+     * @testWith ["Not a slug"]
      *           ["not-á-slug"]
      *           ["not-@-slug"]
      */
@@ -91,7 +92,7 @@ public function testCustomRegexInvalidSlugs($slug)
 
     /**
      * @testWith ["slug"]
-     * @testWith ["test1234"]
+     *           ["test1234"]
      */
     public function testCustomRegexValidSlugs($slug)
     {
@@ -101,4 +102,16 @@ public function testCustomRegexValidSlugs($slug)
 
         $this->assertNoViolation();
     }
+
+    /**
+     * @testWith ["PHP"]
+     *           ["Symfony is cool"]
+     *           ["Lorem ipsum dolor sit amet"]
+     */
+    public function testAcceptAsciiSluggerResults(string $text)
+    {
+        $this->validator->validate((new AsciiSlugger())->slug($text), new Slug());
+
+        $this->assertNoViolation();
+    }
 }

composer.json

@@ -38,6 +38,7 @@
         "symfony/mime": "^6.4|^7.0",
         "symfony/property-access": "^6.4|^7.0",
         "symfony/property-info": "^6.4|^7.0",
+        "symfony/string": "^6.4|^7.0",
         "symfony/translation": "^6.4.3|^7.0.3",
         "symfony/type-info": "^7.1",
         "egulias/email-validator": "^2.1.10|^3|^4"