Skip to content

Fix Doctrine Persistence deprecation #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

jmsche
Copy link
Contributor

@jmsche jmsche commented Jun 1, 2023

Q A
Bug fix? yes (kinda)
New feature? no
Tickets N/A
License MIT

This tiny PR fixes a deprecation coming from doctrine/persistence.

@jmsche
Copy link
Contributor Author

jmsche commented Jun 1, 2023

Hmm the CI failures seem unrelated.

@sneakyvv
Copy link
Contributor

sneakyvv commented Jun 2, 2023

@jmsche You should trigger a rerun of the Turbo tests, since that test sometimes fails. Your change fixed the deprecation issues. 👍
PS: triggering a rerun can be done by amending your commit and force-pushing the new commit.

@jmsche jmsche force-pushed the fix-doctrine-deprecation branch from 189f783 to 4d5fe4a Compare June 2, 2023 08:15
@jmsche
Copy link
Contributor Author

jmsche commented Jun 2, 2023

Thanks @sneakyvv :)

It's only getting worse :D

@weaverryan
Copy link
Member

Thanks! I'm going to merge 919 also and see where that leaves us

@weaverryan weaverryan merged commit 6d46f90 into symfony:2.x Jun 2, 2023
@jmsche jmsche deleted the fix-doctrine-deprecation branch June 16, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants