Skip to content

[TwigComponent] Fix escaping of Alpine.js attribute keys containing numeric characters #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

klausi85
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
Docs? no
License MIT

Alpine.js attribute keys like @input.debounce.500ms (see https://alpinejs.dev/directives/on#debounce) will now be correctly handled without being escaped.

@carsonbot carsonbot added Bug Bug Fix TwigComponent Status: Needs Review Needs to be reviewed labels Jun 12, 2025
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Can you update ComponentAttributesTest test to prevent any regressions on this?

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jun 13, 2025
@klausi85
Copy link
Contributor Author

Thanks for the fix!

Can you update ComponentAttributesTest test to prevent any regressions on this?

Sorry missed that part, I will do that asap.

@klausi85 klausi85 requested a review from Kocal June 13, 2025 11:43
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Reviewed Has been reviewed by a maintainer labels Jun 13, 2025
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jun 13, 2025
@Kocal
Copy link
Member

Kocal commented Jun 13, 2025

Thank you @klausi85.

@Kocal Kocal merged commit 7c1de1f into symfony:2.x Jun 13, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer TwigComponent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants