Skip to content

[Typed] Deprecate the package #2809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

[Typed] Deprecate the package #2809

merged 1 commit into from
Jun 3, 2025

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Jun 2, 2025 •
edited
Loading

Q A
Bug fix? no
New feature? yes
Docs? no
Issues Fix #2740
License MIT

Let's use this package as a reference, for the next packages deprecation PRs.

@carsonbot carsonbot added Feature New Feature Typed Status: Needs Review Needs to be reviewed labels Jun 2, 2025
@Kocal Kocal mentioned this pull request May 16, 2025
Open
2 tasks
@Kocal Kocal force-pushed the 2740-deprecate-typed branch from e7d8911 to 7487341 Compare June 2, 2025 06:58
@Kocal Kocal requested review from kbond and smnandre June 2, 2025 07:37
kbond
kbond approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the migration steps!

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jun 2, 2025
Kocal
Kocal commented Jun 2, 2025
View reviewed changes
Copy link
Member Author

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also ignore deprecations in ux.symfony.com tests

smnandre
smnandre reviewed Jun 2, 2025
View reviewed changes
smnandre
smnandre reviewed Jun 2, 2025
View reviewed changes
smnandre
smnandre reviewed Jun 2, 2025
View reviewed changes
smnandre
smnandre reviewed Jun 2, 2025
View reviewed changes
smnandre
smnandre reviewed Jun 2, 2025
View reviewed changes
smnandre
smnandre reviewed Jun 2, 2025
View reviewed changes
@Kocal Kocal force-pushed the 2740-deprecate-typed branch from 882b2f6 to 1bb614e Compare June 3, 2025 06:31
@Kocal @smnandre
[Typed] Deprecate the package
8e96fce 
Co-authored-by: Simon André <smn.andre@gmail.com>
@Kocal Kocal force-pushed the 2740-deprecate-typed branch from 1bb614e to 8e96fce Compare June 3, 2025 06:47
@Kocal Kocal merged commit c160eae into symfony:2.x Jun 3, 2025
24 checks passed
@Kocal Kocal deleted the 2740-deprecate-typed branch June 3, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smnandre smnandre smnandre left review comments

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
Deprecation Feature New Feature Status: Reviewed Has been reviewed by a maintainer Typed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate Typed for 2.x, remove it for 3.x
4 participants
@Kocal @kbond @smnandre @carsonbot