[Icons] Docs: Some typos #2781
Merged
[Icons] Docs: Some typos #2781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
approved these changes
May 28, 2025
| @@ -237,7 +237,7 @@ site *on-demand*: | |||
| fetched (and cached). | |||
|
|
|||
| That's all. This works by using the `Iconify`_ API (to which `ux.symfony.com/icons`_ | |||
| is a frontend for) to fetch the icon and render it in place. This icon is then cached | |||
| is a frontend) to fetch the icon and render it in place. This icon is then cached | |||
There was a problem hiding this comment.
I'm not super-fluent in english, but to me the previous version sounds better, no?
There was a problem hiding this comment.
Just switch the parts:
ux.symfony.com/iconsis a frontend for the the Iconify API
=> OK
ux.symfony.com/iconsis a frontend to the the Iconify API
=> OK
ux.symfony.com/iconsis a frontend to for the the Iconify API
=> Not OK
carsonbot
added
Status: Reviewed
|
Thank you @ThomasLandauer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page: https://symfony.com/bundles/ux-icons/current/index.html