key is more reliable with child components #2699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a concrete example/setup so we can track this done later ? |
smnandre
added
docs
smnandre
approved these changes
Apr 30, 2025
Kocal
added a commit
that referenced
this pull request
May 23, 2025
This PR was merged into the 2.x branch. Discussion ---------- docs: remove oldest versionadded | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | yes | Issues | Fix #... | License | MIT A while back, I removed the oldest `@versionadded` annotations—`@weaverryan` reminded me of this in #2699. This PR repeats that cleanup by dropping any `@versionadded` tags that are more than two years old. Commits ------- 6fad96d docs: remove oldest versionadded
symfony-splitter
pushed a commit
to symfony/ux-autocomplete
that referenced
this pull request
May 23, 2025
This PR was merged into the 2.x branch. Discussion ---------- docs: remove oldest versionadded | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | yes | Issues | Fix #... | License | MIT A while back, I removed the oldest `@versionadded` annotations—`@weaverryan` reminded me of this in symfony/ux#2699. This PR repeats that cleanup by dropping any `@versionadded` tags that are more than two years old. Commits ------- 6fad96dd4b5 docs: remove oldest versionadded
symfony-splitter
pushed a commit
to symfony/ux-live-component
that referenced
this pull request
May 23, 2025
This PR was merged into the 2.x branch. Discussion ---------- docs: remove oldest versionadded | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | yes | Issues | Fix #... | License | MIT A while back, I removed the oldest `@versionadded` annotations—`@weaverryan` reminded me of this in symfony/ux#2699. This PR repeats that cleanup by dropping any `@versionadded` tags that are more than two years old. Commits ------- 6fad96dd4b5 docs: remove oldest versionadded
|
Thank you @weaverryan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't track down why, but for child components,
keyis more reliable. Whenidis used and a child requires re-rendering (because input props changed), the dummy element returned by https://github.com/symfony/ux/blob/2.x/src/LiveComponent/src/EventListener/InterceptChildComponentRenderSubscriber.php will not have anid, but withkeyit will. Smells like a bug, butkeyworks