[Icons] Patch to handle Iconify API change #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, the iconify API returned "200" even when the resource (icon data, svg) did not exist. It will change in the next days. This patch allow the `ux:icon:lock` and the CacheWarmer to work after this change.
kbond
approved these changes
Oct 20, 2024
carsonbot
added
Status: Reviewed
Kocal
approved these changes
Oct 20, 2024
|
Thanks Simon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the iconify API returned "200" even when the resource (icon data, svg) did not exist.
It will change in the next days
This patch allow the
ux:icon:lockand the CacheWarmer to work after this change.