Skip to content

[Map] Change "BeforeConnect" for "BeforeCreate" in documentation #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Aug 9, 2024

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

Technically the code is not wrong, but when listening for events ux:map:marker:before-create or ux:map:info-window:before-create, you can expect the method to be named *BeforeCreate and not *BeforeConnect.

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Aug 9, 2024
@javiereguiluz
Copy link
Member

Yes, it looks more consistent now. Thanks Hugo.

@javiereguiluz javiereguiluz merged commit 6b8b305 into symfony:2.x Aug 9, 2024
2 checks passed
@Kocal Kocal deleted the fix/doc-ux-map-before-create branch August 9, 2024 08:41
@Kocal Kocal added the Map label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants