[LiveComponent] improve errors when LiveArg is missing for live action and live listener #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Feature
smnandre
reviewed
Jun 10, 2024
| @@ -274,6 +275,14 @@ public function onKernelException(ExceptionEvent $event): void | |||
| return; | |||
| } | |||
|
|
|||
| if ($event->getThrowable() instanceof RuntimeException) { | |||
| if (str_starts_with($event->getThrowable()->getMessage(), 'Could not resolve argument $key')) { | |||
There was a problem hiding this comment.
Can we use a class/interface here?
|
What will be displayed if the LiveComponent is not tagged with controller_arguments (or does not extends AbstractController) ? |
|
Hmm ok ... It's because of the NotTaggedControllerValueResolver registered only in debug. We should see this message instead, already better. And, guess what..... all this is related to our LiveArg implementation 🤖 So i suggest we take some time (when we can) to make a good, stable & durable fix for LiveArg .. and we won't have this problem anymore :à |
Kocal
requested changes
Jan 5, 2025
carsonbot
added
Status: Needs Work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the error message when a LIveArg is missing on live action or live event. Here is the new error and the previous one.