Skip to content

[LiveComponent] Add better error message when hydrating dates #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

1ed
Copy link
Contributor

@1ed 1ed commented Jan 31, 2024

Q A
Bug fix? no
New feature? yes
Issues -
License MIT

Instead of

Return value must be of type ?object, bool returned"

return a proper error message

The model path "createdAt" was sent invalid date data "0" or in an invalid format. Make sure it's a valid date and it matches the expected format "Y. m. d.".

Not sure if it's a bugfix or feature. Maybe the wording can be tweaked.

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Jan 31, 2024
@1ed 1ed force-pushed the better-date-hydration-error-message branch from f3ad540 to 14fb75e Compare January 31, 2024 09:15
@weaverryan
Copy link
Member

Love this! Thank you Gábor!

@weaverryan weaverryan merged commit c2d029f into symfony:2.x Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants