[LiveComponent] Make LiveComponentHydrator work without Serializer #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebMamba
reviewed
Dec 17, 2023
Comment on lines
+360
to
+365
| if (null === $this->serializer) { | ||
| throw new \LogicException(sprintf('The LiveProp "%s" on component "%s" has "useSerializerForHydration: true", but no serializer has been set.', $propMetadata->getName(), $parentObject::class)); | ||
| } | ||
| if (!$this->serializer instanceof NormalizerInterface) { | ||
| throw new \LogicException(sprintf('The LiveProp "%s" on component "%s" has "useSerializerForHydration: true", but the given serializer does not implement NormalizerInterface.', $propMetadata->getName(), $parentObject::class)); | ||
| } |
There was a problem hiding this comment.
Do we need those two errors? How those two errors could happen?
There was a problem hiding this comment.
The null test is required (it's not because symfony/serializer is installed that it is configured in Symfony).
The instance test is necessary because the constructor argument is NormalizerInterface|DenormalizerInterface .. so one could be normalizer without beeing denormalizer :|
weaverryan
force-pushed
the
fix/hydrator-serializer
branch
from
363cfae to
10ca442
Compare
|
Thanks Simon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow nullable "serializer" argument in LiveComponentHydrator constructor.
(fix #1340 and complete #1327)